Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(arvr/xplat): update imports to resolve packaged virtualized list from react-native #36035

Closed
wants to merge 2 commits into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Feb 1, 2023

Summary: Changelog: [Internal]

Differential Revision: D42805202

gabrieldonadel and others added 2 commits February 1, 2023 11:14
…book#35406)

Summary:
This PR moves `VirtualizedList`, `VirtualizedSectionList`, and its files to a separate package called `react-native/virtualized-lists` located under `packages/virtualized-lists` as proposed on facebook#35263

## Changelog

[General] [Changed] - Move virtualized lists to react-native/virtualized-lists package

Pull Request resolved: facebook#35406

Test Plan:
1. Open the RNTester app and navigate to `FlatList` or `SectionList` page
2. Test virtualized lists through the many sections

https://user-images.githubusercontent.com/11707729/202878843-2b1322f5-cfee-484e-aaf3-d8d4dc0b96cc.mov

Differential Revision: D41745930

Pulled By: hoxyq

fbshipit-source-id: 67a971a3f06895bce360a7463c66a6b1f334f46b
…list from react-native

Summary: Changelog: [Internal]

Differential Revision: D42805202

fbshipit-source-id: f4065004a95b4e434a379c16f61661cde98f38f6
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 1, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42805202

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 2bd347d

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,464,553 +425
android hermes armeabi-v7a 7,785,909 +422
android hermes x86 8,938,374 +419
android hermes x86_64 8,796,593 +419
android jsc arm64-v8a 9,649,969 +307
android jsc armeabi-v7a 8,385,136 +313
android jsc x86 9,712,583 +310
android jsc x86_64 10,189,544 +307

Base commit: 95b9952
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1479b2a.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…list from react-native (facebook#36035)

Summary:
Pull Request resolved: facebook#36035

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D42805202

fbshipit-source-id: 1f1d6e36ec6e19a1b46ce340be095bb60b8048f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants