Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][CI] Fix prepare hermes workspace warnings in GHA #45494

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jul 17, 2024

Summary:

Some of the previous commits changed the names of the parameters on one side and not in another, and GHA is emitting some warnings. This change should fix them

Changelog:

[Internal] - Fix GHA CI warnings

Test Plan:

BEFORE AFTER
Screenshot 2024-07-17 at 14 20 54 Screenshot 2024-07-17 at 14 23 31

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 17, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-ci-warnings branch from c075362 to 53d894d Compare July 17, 2024 12:22
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-ci-warnings branch from 53d894d to 6e74992 Compare July 17, 2024 12:23
@cipolleschi cipolleschi marked this pull request as ready for review July 17, 2024 12:24
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,353,610 -8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,549,449 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c1b4133
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 17, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in dbbb406.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in dbbb406

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants