Introduce ImageRequestParams #47723
Open
Introduce ImageRequestParams #47723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66172570 |
dmytrorykun
force-pushed
the
export-D66172570
branch
from
270c526
to
22d9e89
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Pull Request resolved: facebook#47723 Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Pull Request resolved: facebook#47723 Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
dmytrorykun
force-pushed
the
export-D66172570
branch
from
22d9e89
to
b918f86
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66172570 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
dmytrorykun
force-pushed
the
export-D66172570
branch
from
b918f86
to
8724a19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66172570 |
dmytrorykun
force-pushed
the
export-D66172570
branch
from
8724a19
to
0bd4096
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
|
This pull request was exported from Phabricator. Differential Revision: D66172570 |
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
Summary: Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
dmytrorykun
force-pushed
the
export-D66172570
branch
from
0bd4096
to
d376a37
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66172570 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: Pull Request resolved: facebook#47723 Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: Pull Request resolved: facebook#47723 Identity of `ImageRequest` is based on `ImageSource` and a subset of `ImageProps`. If any of those change, the request must be recreated and resubmitted. Currently, the relevant subset of ImageProps is represented by a single `blurRadius` prop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce the `ImageRequestParams` type that will wrap all the relevant props. The alternative approach to pass `ImageProps` directly to `ImageManager` is worse because it would introduce dependency cycle between `ImageManager` and the `Image` component, and also it would require to store the props in State, which is bad. Changelog: [Internal] Differential Revision: D66172570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Identity of
ImageRequestis based onImageSourceand a subset ofImageProps. If any of those change, the request must be recreated and resubmitted.Currently, the relevant subset of ImageProps is represented by a single
blurRadiusprop. This list will grow in the future. In order to simplify adding new props to the image request, we introduce theImageRequestParamstype that will wrap all the relevant props.The alternative approach to pass
ImagePropsdirectly toImageManageris worse because it would introduce dependency cycle betweenImageManagerand theImagecomponent, and also it would require to store the props in State, which is bad.Changelog: [Internal]
Differential Revision: D66172570