Remove DeprecatedInNewArchitecture for ReactPropHolder annotation #47745
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66216729 |
|
This pull request was exported from Phabricator. Differential Revision: D66216729 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 21, 2024
…cebook#47745) Summary: Pull Request resolved: facebook#47745 Remove DeprecatedInNewArchitecture for ReactPropHolder annotation ReactProp is still used in new arch, we might remove this annotation in the future but it will be independent of new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216729
mdvacca
force-pushed
the
export-D66216729
branch
from
ab7207d
to
11a3bfd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66216729 |
…cebook#47745) Summary: Remove DeprecatedInNewArchitecture for ReactPropHolder annotation ReactProp is still used in new arch, we might remove this annotation in the future but it will be independent of new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216729
mdvacca
force-pushed
the
export-D66216729
branch
from
11a3bfd
to
75fdfb4
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 22, 2024
…tation (facebook#47745) Summary: Remove DeprecatedInNewArchitecture for ReactPropHolder annotation ReactProp is still used in new arch, we might remove this annotation in the future but it will be independent of new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216729
|
This pull request was exported from Phabricator. Differential Revision: D66216729 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 22, 2024
…tation (facebook#47745) Summary: Remove DeprecatedInNewArchitecture for ReactPropHolder annotation ReactProp is still used in new arch, we might remove this annotation in the future but it will be independent of new arch changelog: [internal] internal Reviewed By: javache Differential Revision: D66216729
|
This pull request has been merged in f03e75d. |
|
This pull request was successfully merged by @mdvacca in f03e75d When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove DeprecatedInNewArchitecture for ReactPropHolder annotation
ReactProp is still used in new arch, we might remove this annotation in the future but it will be independent of new arch
changelog: [internal] internal
Differential Revision: D66216729