fixed facebook-github-bot command duplication #6550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot shipit |
|
By analyzing the blame information on this pull request, we identified @bestander, @mkonicek and @janicduplessis to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| @@ -35,7 +35,3 @@ reopen | |||
| @facebook-github-bot feature | |||
| comment Hey {issue_author}! Thanks for opening the issue, however it looks like a feature request. As noted in the [Issue template](https://github.com/facebook/react-native/blob/master/ISSUE_TEMPLATE.md) we'd like to use the GitHub issues to track bugs only. Can you implement the feature as a standalone npm module? If not consider sending a pull request or a create an entry on [Product Pains](https://productpains.com/product/react-native). It has a voting system and if the feature gets upvoted enough it might get implemented. | |||
| feature | |||
There was a problem hiding this comment.
Consider adding "Closing this issue." as a last sentence.
|
@facebook-github-bot shipit |
|
@facebook-github-bot shipit |
|
@bestander updated the pull request. |
|
@facebook-github-bot shipit |
1 similar comment
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
jeffchienzabinet
pushed a commit
to jeffchienzabinet/react-native
that referenced
this pull request
Mar 21, 2016
Summary:clowns Closes facebook#6550 Differential Revision: D3074924 Pulled By: mkonicek fb-gh-sync-id: c014726bfc42c8d8820ec4cca13ec252ebdc50fc shipit-source-id: c014726bfc42c8d8820ec4cca13ec252ebdc50fc
ghost
pushed a commit
that referenced
this pull request
Jun 21, 2016
Summary: With accessibility prop set to true, it is not possible to access childern elements. This makes it impossible to test Components with appium and releatives. This commit adds support to change accessiblity property on Touchable elements to overcome the aforementioned issue. Closes #8243 Differential Revision: D3462949 Pulled By: javache fbshipit-source-id: 65ce6507a1619218ab5b527c970a74af197ef462
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: With accessibility prop set to true, it is not possible to access childern elements. This makes it impossible to test Components with appium and releatives. This commit adds support to change accessiblity property on Touchable elements to overcome the aforementioned issue. Closes facebook#8243 Differential Revision: D3462949 Pulled By: javache fbshipit-source-id: 65ce6507a1619218ab5b527c970a74af197ef462
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: With accessibility prop set to true, it is not possible to access childern elements. This makes it impossible to test Components with appium and releatives. This commit adds support to change accessiblity property on Touchable elements to overcome the aforementioned issue. Closes facebook#8243 Differential Revision: D3462949 Pulled By: javache fbshipit-source-id: 65ce6507a1619218ab5b527c970a74af197ef462
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clowns