Update type check for NavigationCardStack

[lgan1989]

The typecheck inside of NavigationCard is PropTypes.any while in NavigationCardStack it is View.propTypes.style.

let's make them consistent to avoid unnecessary warnings. (e.g. trying to pass a animationStyle as cardStyle)

[ghost]

By analyzing the blame information on this pull request, we identified @hedgerwang and @jmurzy to be potential reviewers.

[ghost]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

[ghost]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[mkonicek]

The typecheck inside of NavigationCard is PropTypes.any while in NavigationCardStack it is View.propTypes.style.

It seems like View.propTypes.style is more accurate? Why not use it in both places? PropTypes.any is an equivalent of no typing.

let's make them consistent to avoid unnecessary warnings. (e.g. trying to pass a animationStyle as cardStyle)

What is animationStyle and why is not a View.propTypes.style?

[lgan1989]

@mkonicek the thing is that NavigationCard's render() is using a Animated.View the style property could be as following:

<Animated.View style={{opacity: this.state.fadeAnim}}> {this.props.children} </Animated.View>

while
this.state = { fadeAnim: new Animated.Value(0), };

[ericvicenti]

Ah, I see the problem. Can't we use Animated.View.propTypes.style?

[lgan1989]

@ericvicenti this could work, although after I changed it to Animated.View.propTypes.style it exposed another issue(warning):

since there is a property in NavigationPropTypes named "position", and it's conflicted with the ViewStylePropTypes check inside of AnimatedImplementation.js@1485.

Although I think this false warning is not critical and it's because the checking itself in AnimatedImplementation is not so precise.

[satya164]

since there is a property in NavigationPropTypes named "position", and it's conflicted with the ViewStylePropTypes check inside of AnimatedImplementation.js@1485.

I have had this issue with one of my modules and I think PropTypes.any is our best best for now.

[ghost]

@lgan1989 updated the pull request - view changes

[ghost]

@lgan1989 updated the pull request - view changes

[facebook-github-bot]

@lgan1989 updated the pull request - view changes

[facebook-github-bot]

@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.