Remove shouldDeprioritizeSubtree from host config (#19124)

No longer being used.
facebook · Jun 12, 2020 · 103ed08 · 103ed08
1 parent 8f05f2b
commit 103ed08
Show file tree

Hide file tree

Showing 17 changed files with 10 additions and 68 deletions.
diff --git a/packages/react-art/src/ReactARTHostConfig.js b/packages/react-art/src/ReactARTHostConfig.js
@@ -323,10 +323,6 @@ export function resetTextContent(domElement) {
   // Noop
 }
 
-export function shouldDeprioritizeSubtree(type, props) {
-  return false;
-}
-
 export function getRootHostContext() {
   return NO_CONTEXT;
 }

diff --git a/packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js b/packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
@@ -91,10 +91,7 @@ describe('ReactDOMServerPartialHydration', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-dom/src/__tests__/ReactUpdates-test.js b/packages/react-dom/src/__tests__/ReactUpdates-test.js
@@ -29,10 +29,7 @@ describe('ReactUpdates', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-dom/src/client/ReactDOMHostConfig.js b/packages/react-dom/src/client/ReactDOMHostConfig.js
@@ -371,12 +371,6 @@ export function shouldSetTextContent(type: string, props: Props): boolean {
   );
 }
 
-export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {
-  // This is obnoxiously specific so that nobody uses it, but we can still opt
-  // in via an infra-level userspace abstraction.
-  return props.hidden === 'unstable-do-not-use-legacy-hidden';
-}
-
 export function createTextInstance(
   text: string,
   rootContainerInstance: Container,

diff --git a/packages/react-native-renderer/src/ReactFabricHostConfig.js b/packages/react-native-renderer/src/ReactFabricHostConfig.js
@@ -329,10 +329,6 @@ export function resetAfterCommit(containerInfo: Container): void {
   // Noop
 }
 
-export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {
-  return false;
-}
-
 export function shouldSetTextContent(type: string, props: Props): boolean {
   // TODO (bvaughn) Revisit this decision.
   // Always returning false simplifies the createInstance() implementation,

diff --git a/packages/react-native-renderer/src/ReactNativeHostConfig.js b/packages/react-native-renderer/src/ReactNativeHostConfig.js
@@ -248,10 +248,6 @@ export const scheduleTimeout = setTimeout;
 export const cancelTimeout = clearTimeout;
 export const noTimeout = -1;
 
-export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {
-  return false;
-}
-
 export function shouldSetTextContent(type: string, props: Props): boolean {
   // TODO (bvaughn) Revisit this decision.
   // Always returning false simplifies the createInstance() implementation,

diff --git a/packages/react-noop-renderer/src/createReactNoop.js b/packages/react-noop-renderer/src/createReactNoop.js
@@ -335,10 +335,6 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
 
     shouldSetTextContent,
 
-    shouldDeprioritizeSubtree(type: string, props: Props): boolean {
-      return !!props.hidden;
-    },
-
     createTextInstance(
       text: string,
       rootContainerInstance: Container,

diff --git a/packages/react-reconciler/src/__tests__/ReactIncremental-test.js b/packages/react-reconciler/src/__tests__/ReactIncremental-test.js
@@ -28,10 +28,7 @@ describe('ReactIncremental', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js b/packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js
@@ -49,10 +49,7 @@ describe('ReactIncrementalErrorHandling', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-reconciler/src/__tests__/ReactIncrementalSideEffects-test.js b/packages/react-reconciler/src/__tests__/ReactIncrementalSideEffects-test.js
@@ -42,10 +42,7 @@ describe('ReactIncrementalSideEffects', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-reconciler/src/__tests__/ReactNewContext-test.js b/packages/react-reconciler/src/__tests__/ReactNewContext-test.js
@@ -46,10 +46,7 @@ describe('ReactNewContext', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-reconciler/src/__tests__/ReactSchedulerIntegration-test.js b/packages/react-reconciler/src/__tests__/ReactSchedulerIntegration-test.js
@@ -57,10 +57,7 @@ describe('ReactSchedulerIntegration', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js b/packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js
@@ -144,10 +144,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js b/packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js
@@ -51,8 +51,6 @@ export const appendInitialChild = $$$hostConfig.appendInitialChild;
 export const finalizeInitialChildren = $$$hostConfig.finalizeInitialChildren;
 export const prepareUpdate = $$$hostConfig.prepareUpdate;
 export const shouldSetTextContent = $$$hostConfig.shouldSetTextContent;
-export const shouldDeprioritizeSubtree =
-  $$$hostConfig.shouldDeprioritizeSubtree;
 export const createTextInstance = $$$hostConfig.createTextInstance;
 export const scheduleTimeout = $$$hostConfig.scheduleTimeout;
 export const cancelTimeout = $$$hostConfig.cancelTimeout;

diff --git a/packages/react-refresh/src/__tests__/ReactFresh-test.js b/packages/react-refresh/src/__tests__/ReactFresh-test.js
@@ -79,10 +79,7 @@ describe('ReactFresh', () => {
   // once the extra div wrapper is no longer neccessary.
   function LegacyHiddenDiv({children, mode}) {
     return (
-      <div
-        hidden={
-          mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-        }>
+      <div hidden={mode === 'hidden'}>
         <React.unstable_LegacyHidden
           mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
           {children}

diff --git a/packages/react-test-renderer/src/ReactTestHostConfig.js b/packages/react-test-renderer/src/ReactTestHostConfig.js
@@ -218,10 +218,6 @@ export function shouldSetTextContent(type: string, props: Props): boolean {
   return false;
 }
 
-export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {
-  return false;
-}
-
 export function createTextInstance(
   text: string,
   rootContainerInstance: Container,

diff --git a/packages/react/src/__tests__/ReactDOMTracing-test.internal.js b/packages/react/src/__tests__/ReactDOMTracing-test.internal.js
@@ -59,10 +59,7 @@ function loadModules() {
 // the extra div wrapper is no longer neccessary.
 function LegacyHiddenDiv({children, mode}) {
   return (
-    <div
-      hidden={
-        mode === 'hidden' ? 'unstable-do-not-use-legacy-hidden' : undefined
-      }>
+    <div hidden={mode === 'hidden'}>
       <React.unstable_LegacyHidden
         mode={mode === 'hidden' ? 'unstable-defer-without-hiding' : mode}>
         {children}