Better handle undefined Error stacks in DevTools error boundary

facebook · Mar 9, 2022 · 4c68c14 · 4c68c14
1 parent 72a933d
commit 4c68c14
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/react-devtools-shared/src/devtools/views/ErrorBoundary/ErrorBoundary.js b/packages/react-devtools-shared/src/devtools/views/ErrorBoundary/ErrorBoundary.js
@@ -49,16 +49,18 @@ export default class ErrorBoundary extends Component<Props, State> {
     const errorMessage =
       typeof error === 'object' &&
       error !== null &&
-      error.hasOwnProperty('message')
+      error.hasOwnProperty('message') &&
+      typeof error.message === 'string'
         ? error.message
-        : String(error);
+        : null;
 
     const isTimeout = error instanceof TimeoutError;
 
     const callStack =
       typeof error === 'object' &&
       error !== null &&
-      error.hasOwnProperty('stack')
+      error.hasOwnProperty('stack') &&
+      typeof error.stack === 'string'
         ? error.stack
             .split('\n')
             .slice(1)