Don't lint against Hooks after conditional throw

Seems like this should be OK. Fixes #14038. Now when tracking paths, we completely ignore segments that end in a throw. In https://eslint.org/docs/developer-guide/code-path-analysis I don't see a way to detect throws other than manually tracking them, so that's what I've done.
facebook · Oct 31, 2018 · fcd4703 · fcd4703
1 parent 169f935
commit fcd4703
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js b/packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js
@@ -261,6 +261,15 @@ eslintTester.run('react-hooks', ReactHooksESLintRule, {
         useState();
       }
     `,
+    `
+      // Valid because exceptions abort rendering
+      function RegressionTest() {
+        if (page == null) {
+          throw new Error('oh no!');
+        }
+        useState();
+      }
+    `,
   ],
   invalid: [
     {

diff --git a/packages/eslint-plugin-react-hooks/src/RulesOfHooks.js b/packages/eslint-plugin-react-hooks/src/RulesOfHooks.js
@@ -139,7 +139,9 @@ export default {
 
           // Compute `paths` and cache it. Guarding against cycles.
           cache.set(segment.id, null);
-          if (segment.prevSegments.length === 0) {
+          if (codePath.thrownSegments.includes(segment)) {
+            paths = 0;
+          } else if (segment.prevSegments.length === 0) {
             paths = 1;
           } else {
             paths = 0;
@@ -199,7 +201,9 @@ export default {
 
           // Compute `paths` and cache it. Guarding against cycles.
           cache.set(segment.id, null);
-          if (segment.nextSegments.length === 0) {
+          if (codePath.thrownSegments.includes(segment)) {
+            paths = 0;
+          } else if (segment.nextSegments.length === 0) {
             paths = 1;
           } else {
             paths = 0;