Ship 15.4.0 #7770

zpao · 2016-09-19T20:59:17Z

This might be a little ways out, but going to start the process. We definitely want to run an RC here and push it through React Native. We'll want other people to play with it too. There's a big packaging change and it has potential to have issues.

gaearon · 2016-10-14T19:34:59Z

I just published 15.4.0-rc.3.

Installation

npm i --save [email protected] [email protected]

If you use snapshot testing:

npm i --save-dev [email protected]

Please report issues!

There is a big change in how internals are organized. We are continuing to split React from ReactDOM internally, and in this release a bunch of internal modules has moved from react/lib/* to react-dom/lib/*. They were never a part of the public API so it's valid as a minor version, but we published this RC so that you have a chance to assess whether you or any libraries you depend on use private APIs, and raise issues with their maintainers before 15.4.0 is stable.

If your package depends on React internal APIs, consider copying the relevant code in your project. React makes no guarantees that any imports from /lib/ folders will ever be supported. They may technically break in any patch version even though we are taking extra steps to make it smooth. As a quick fix, you can replace react/lib/ with react-dom/lib/ and it will likely work, but many of those modules might get removed or further renamed in React 16. Please don't use internal modules of React.

If you found an issue in a popular React-related library that breaks in 15.4.0, please post here so that we keep track of them.

faalsh · 2016-10-15T08:51:33Z

I'm getting:

Module not found: Error: Cannot resolve module 'react/lib/ReactMount'

gaearon · 2016-10-15T09:37:13Z

@faalsh

If you didn't mean to install the RC please run:

npm i --save react@latest react-dom@latest

We published RC4 as latest by mistake but it wasn't meant to be installed automatically.

If you are trying out RC on purpose, please look at which library tries to import react/lib/ReactMount. It's likely not your code, is it? Then file an issue with that library.

faalsh · 2016-10-15T14:51:41Z

@gaearon I'm trying out RC on purpose. Thanks for the tip, the error is caused by react-hot-loader.

gaearon · 2016-10-15T16:48:50Z

RHL 1.x (which is the one relying on this internal module) has been unsupported for more than a year. Please migrate to 3.x if you'd like to keep using it. There are instructions linked from the first paragraph in its README.

thisbejim · 2016-10-21T00:22:56Z

Hi @gaearon, I am currently on [email protected] [email protected] [email protected] and [email protected] and when snapshot testing material-ui components with react-test-renderer I get the following error:

Invariant Violation: getNodeFromInstance: Invalid argument.

at invariant (node_modules/fbjs/lib/invariant.js:38:15)
      at Object.getNodeFromInstance (node_modules/react-dom/lib/ReactDOMComponentTree.js:155:77)
      at Object.findDOMNode (node_modules/react-dom/lib/findDOMNode.js:49:41)
      at ListItem.applyFocusState (node_modules/material-ui/List/ListItem.js:300:43)
      at MenuItem.applyFocusState (node_modules/material-ui/MenuItem/MenuItem.js:198:26)
      at MenuItem.componentDidMount (node_modules/material-ui/MenuItem/MenuItem.js:167:12)
      at node_modules/react-test-renderer/lib/ReactCompositeComponent.js:265:25
      at measureLifeCyclePerf (node_modules/react-test-renderer/lib/ReactCompositeComponent.js:75:12)
      at node_modules/react-test-renderer/lib/ReactCompositeComponent.js:264:11
      at CallbackQueue.notifyAll (node_modules/react-test-renderer/lib/CallbackQueue.js:76:22)
      at ReactTestReconcileTransaction.ON_DOM_READY_QUEUEING.close (node_modules/react-test-renderer/lib/ReactTestReconcileTransaction.js:36:26)
      at ReactTestReconcileTransaction.TransactionImpl.closeAll (node_modules/react-test-renderer/lib/Transaction.js:206:25)
      at ReactTestReconcileTransaction.TransactionImpl.perform (node_modules/react-test-renderer/lib/Transaction.js:153:16)
      at batchedMountComponentIntoNode (node_modules/react-test-renderer/lib/ReactTestMount.js:69:27)
      at ReactDefaultBatchingStrategyTransaction.TransactionImpl.perform (node_modules/react-test-renderer/lib/Transaction.js:140:20)
      at Object.ReactDefaultBatchingStrategy.batchedUpdates (node_modules/react-test-renderer/lib/ReactDefaultBatchingStrategy.js:62:26)
      at Object.batchedUpdates (node_modules/react-test-renderer/lib/ReactUpdates.js:97:27)
      at Object.ReactTestMount.render [as create] (node_modules/react-test-renderer/lib/ReactTestMount.js:125:18)
      at Object.<anonymous> (src/components/app/__tests__/app.js:60:68)
      at process._tickCallback (internal/process/next_tick.js:103:7)

Repro if needed.

Any insights? Thanks.

gaearon · 2016-10-21T12:05:48Z

@thisbejim It's not a regression though, is it? Did it ever work before?

@aweary Can you look at #7770 (comment) please? My intuition is that we support mock "DOM" refs but not findDOMNode() at the moment.

aweary · 2016-10-21T15:45:37Z

@gaearon yupp, findDOMNodesupport was never implemented. This error is technically new since in 15.3.2 you would get the injectEnvironment() error before your tests had a chance to even call findDOMNode, but it's not technically a regression since it never worked.

I can look into what it would take for implementing findDOMNode support 👍

thisbejim · 2016-10-24T00:12:04Z

@gaearon Yeah my bad, I had been looking through other issues and wrongly assumed this was something that was planned to be fixed for this release.

Thank you for taking a look, @aweary, I appreciate your time and effort.

In the meantime are there any workarounds? Cheers.

gaearon · 2016-10-31T13:53:22Z

@thisbejim Would you be interested in fixing this?

aweary · 2016-10-31T14:08:27Z

@gaearon I do have some work done towards this, just didn't have a chance to finish it last week.

That said, if you want to work on this @thisbejim feel free to! 😄

thisbejim · 2016-11-01T04:38:36Z

@gaearon @aweary As much as I'd love to help out I think it is very likely that this issue is way over my head. Will take a look at what Aweary is doing though to try and gain a better understanding of the problem.

aweary · 2016-11-05T15:16:17Z

@thisbejim just in case you missed it, we ended up concluding that supporting findDOMNode with the test renderer wasn't a good idea, see here

thisbejim · 2016-11-07T05:53:58Z

Thanks for the update @aweary, much appreciated.

Update: For anyone else who has the findDOMNode error, the solution is to use Enzyme and enzyme-to-json to be compatible with snapshot testing.

aaron-axisa · 2016-11-07T13:25:55Z

I am encountering some issues with my react project using 15.4.0-rc.4 when trying to setup jest and enzyme. (More details here: stackOverflow Question )

Edit: fixed. Mostly merely dependency issues

aaron-axisa · 2016-11-08T16:03:04Z

I have however found an issue with the library chai-enzyme

It requires react/lib/ReactTestUtils (which now moved)


+-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| |   +-- [email protected]
| |   `-- [email protected]
| +-- react@^0.14.8 || ^15.0.1
| `-- [email protected]
|   +-- [email protected]
|   +-- [email protected]
|   | `-- [email protected]
|   +-- react@^15.3.2
|   +-- [email protected]
|   +-- [email protected]
|   | `-- [email protected]
|   +-- [email protected]
|   | +-- [email protected]
|   | `-- [email protected]
|   `-- [email protected]

gaearon · 2016-11-08T20:00:54Z

I have however found an issue with the library chai-enzyme

Please file it with that library.

gaearon · 2016-11-08T20:27:31Z

Reminder to whoever releases this: error code process.

sophiebits · 2016-11-16T14:59:45Z

cc @aweary, @bgnorlov, @chenglou, @gaearon, @goatslacker, @hkal, @jedwards1211, @jessebeach, @keyanzhang, @mnpenner, @nhunzaker, @sebmarkbage – your changes are now shipped in React 15.4!

https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html

aweary mentioned this issue Oct 4, 2016

injectEnvironment called twice: react-test-renderer and react-dom #7386

Closed

bsr203 mentioned this issue Oct 14, 2016

CSSPropertyOperations moved to react-dom tajo/react-portal#103

Closed

calesce mentioned this issue Oct 15, 2016

Error on React 15.4.0-rc.4 gaearon/react-hot-loader#400

Closed

sheepsteak mentioned this issue Oct 17, 2016

Move React from dependencies to peerDependencies styled-components/styled-components#93

Merged

tschaub mentioned this issue Oct 18, 2016

Remove dependency on React internals onefinestay/react-daterange-picker#151

Open

gaearon mentioned this issue Oct 19, 2016

Invariant Violation: ReactCompositeComponent: injectEnvironment() can only be called once. jestjs/jest#1353

Closed

thisbejim mentioned this issue Oct 20, 2016

Update to be compatible with React 15.4 zilverline/react-tap-event-plugin#82

Merged

dsblv mentioned this issue Oct 20, 2016

Aviod using React's internal modules reactjs/react-art#103

Open

dsblv mentioned this issue Oct 21, 2016

Require reconciler code from ReactDOM reactjs/react-art#104

Closed

aweary mentioned this issue Oct 31, 2016

[WIP] Set _hostNode in mountComponent / receiveComponent #8164

Closed

arb mentioned this issue Nov 14, 2016

refactor(shallowCompare) changed to use reacts internal func ubilabs/react-geosuggest#222

Merged

4 tasks

sophiebits closed this as completed Nov 16, 2016

This was referenced Nov 16, 2016

Problems updating to React 15.4.0 #8302

Closed

15.4 minor wasn't supposed to break so much stuff, was it? #8303

Closed

react-addons-test-utils 15.4.0 now depends on react-dom instead of react #8314

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ship 15.4.0 #7770

Ship 15.4.0 #7770

zpao commented Sep 19, 2016

gaearon commented Oct 14, 2016 •

edited

Loading

faalsh commented Oct 15, 2016

gaearon commented Oct 15, 2016

faalsh commented Oct 15, 2016

gaearon commented Oct 15, 2016

thisbejim commented Oct 21, 2016 •

edited

Loading

gaearon commented Oct 21, 2016

aweary commented Oct 21, 2016

thisbejim commented Oct 24, 2016 •

edited

Loading

gaearon commented Oct 31, 2016

aweary commented Oct 31, 2016 •

edited

Loading

thisbejim commented Nov 1, 2016

aweary commented Nov 5, 2016

thisbejim commented Nov 7, 2016 •

edited

Loading

aaron-axisa commented Nov 7, 2016 •

edited

Loading

aaron-axisa commented Nov 8, 2016 •

edited

Loading

gaearon commented Nov 8, 2016

gaearon commented Nov 8, 2016

sophiebits commented Nov 16, 2016

Ship 15.4.0 #7770

Ship 15.4.0 #7770

Comments

zpao commented Sep 19, 2016

gaearon commented Oct 14, 2016 • edited Loading

Installation

Please report issues!

faalsh commented Oct 15, 2016

gaearon commented Oct 15, 2016

faalsh commented Oct 15, 2016

gaearon commented Oct 15, 2016

thisbejim commented Oct 21, 2016 • edited Loading

gaearon commented Oct 21, 2016

aweary commented Oct 21, 2016

thisbejim commented Oct 24, 2016 • edited Loading

gaearon commented Oct 31, 2016

aweary commented Oct 31, 2016 • edited Loading

thisbejim commented Nov 1, 2016

aweary commented Nov 5, 2016

thisbejim commented Nov 7, 2016 • edited Loading

aaron-axisa commented Nov 7, 2016 • edited Loading

aaron-axisa commented Nov 8, 2016 • edited Loading

gaearon commented Nov 8, 2016

gaearon commented Nov 8, 2016

sophiebits commented Nov 16, 2016

gaearon commented Oct 14, 2016 •

edited

Loading

thisbejim commented Oct 21, 2016 •

edited

Loading

thisbejim commented Oct 24, 2016 •

edited

Loading

aweary commented Oct 31, 2016 •

edited

Loading

thisbejim commented Nov 7, 2016 •

edited

Loading

aaron-axisa commented Nov 7, 2016 •

edited

Loading

aaron-axisa commented Nov 8, 2016 •

edited

Loading