move augmentClass definition above SyntheticEvent Proxy replacement #10011
Conversation
|
The browser mentioned in #10010 is QTWebkit, which appears to be an unofficial fork of Webkit. While this change is trivial, I'm hesitant to include changes meant to address dev-only issues in unsupported browsers. The usage of |
|
We could get it in but there's no guarantee we won't break again. |
We learned that the underlying issue was related to react-dom's SyntheticEvent.augmentClass function being undefined. This seems to be caused by attempted property assignment after the SyntheticEvent had been replaced by a Proxy of itself. This works fine in Chromium et al, but QtWebKit doesn't deal with Proxy Event objects well. Moving the augmentClass definition and assignment up above the Proxy stuff resolves the issue in a PR to React: facebook/react#10011
|
@gaearon do you want to make the call here? It's a (seemingly) innocent change, but I'm hesitant to accept since it sets a precedence for including changes for unsupported environments. But it's up to you. |
|
If it doesn't break anything I'm cool with taking it. |
|
Cool, I'll verify everything looks OK locally and merge if so |
|
Seems fine to me, I'll get it in. |
Before submitting a pull request, please make sure the following is done:
master.npm test).npm run lint).npm run prettier).npm run flow)../scripts/fiber/record-testsbefore submitting the pull request, and commit the resulting changes.