Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update thinking-in-react.md to filter products in FilterableProductTable #10821

Conversation

danielsbird
Copy link

This PR updates the Thinking In React example by moving the code that filters the products from the ProductTable component to the FilterableProductTable component. See issue #10808 for more details.

@danielsbird
Copy link
Author

Looks like #10846 created some conflicts with this PR - specifically with the embedded CodePen examples. I will update this PR.

@danielsbird danielsbird force-pushed the update-thinking-in-react-example-doc branch from 2869b01 to 3bee629 Compare September 30, 2017 02:28
@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 3bee629

https://deploy-preview-10821--reactjs.netlify.com

@bvaughn bvaughn changed the title Update thinking-in-react.md to filter products in FilterableProductTable [website] Update thinking-in-react.md to filter products in FilterableProductTable Oct 3, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Thank you for submitting this PR! 😄

Unfortunately the documentation and source code for reactjs.org has been moved to a different repository: https://github.com/reactjs/reactjs.org

If you are willing, please open a new PR there. Sorry for the inconvenience!

(For more backstory on why we moved to a new repo, see issue #11075)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants