chore: remove unnecessary constant #12738
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
gebilaoxiong
changed the title
gebilaoxiong
force-pushed
the
remove-unnecessary-constant
branch
from
8ee28a5
to
03639d3
Compare
gebilaoxiong
force-pushed
the
remove-unnecessary-constant
branch
from
03639d3
to
81bd838
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gebilaoxiong
force-pushed
the
remove-unnecessary-constant
branch
from
81bd838
to
39add47
Compare
gebilaoxiong
force-pushed
the
remove-unnecessary-constant
branch
from
39add47
to
0d3a6e8
Compare
|
Thanks, but I think it was named intentionally. There's no harm in keeping it (the compiler will inline it so it doesn't affect the code size), it adds some clarity, and in general we try to avoid code style-only changes unless they also fix bugs. Appreciate the PR though! |
remove unnecessary constant
in ReactDOM.js#L1036-L1037