Shallow renderer: pass component instance to setState updater as this
#12784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
May 11, 2018
bvaughn
reviewed
May 11, 2018
| @@ -298,7 +298,7 @@ class Updater { | |||
| const currentState = this._renderer._newState || publicInstance.state; | |||
|
|
|||
| if (typeof partialState === 'function') { | |||
| partialState = partialState(currentState, publicInstance.props); | |||
| partialState = partialState.call(publicInstance, currentState, publicInstance.props); | |||
There was a problem hiding this comment.
Run yarn prettier to reformat this file and CI should pass! 😄
|
It's kinda weird that we support that btw. I wonder why. |
|
One possible usecase is to have updaters as instance methods: Of course, |
Yeah, the problem is that if you need something instance-y in the updater usually it means the code is wrong. Anyway, thanks for fixing. |
bvaughn
approved these changes
May 11, 2018
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…s` (#12784) * Shallow renderer: pass component instance to setState updater as `this` * Run prettier
This was referenced Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes react-test-renderer behaviour aligned with one of react-reconciler, see
react/packages/react-reconciler/src/ReactUpdateQueue.js
Line 413 in b548b3c