Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set current owner in prod too #12804

Closed
wants to merge 1 commit into from
Closed

Set current owner in prod too #12804

wants to merge 1 commit into from

Conversation

sophiebits
Copy link
Collaborator

This can change behavior.

Follow-up to #12777.

@sophiebits
Set current owner in prod too
f2a1b87 
This can change behavior.
@acdlite
Copy link
Collaborator

acdlite commented May 14, 2018 •
edited
Loading

Looks fine, but for functional components, ReactCurrentOwner is only used for warnings, right? Assuming that's correct, we should use ReactDebugCurrentFiber instead and only set it in DEV. Maybe this would be a good first task for Chang.

@acdlite
Copy link
Collaborator

acdlite commented May 14, 2018

I guess IndeterminateComponent makes this trickier because we don't know if it's a class component or functional component until we call it.

Akshat-Jain
Akshat-Jain reviewed Sep 14, 2018
View reviewed changes
Copy link

@Akshat-Jain Akshat-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts. Thanks :-)

@stale
Copy link

stale bot commented Jan 10, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 17, 2020

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akshat-Jain Akshat-Jain Akshat-Jain left review comments

@acdlite acdlite acdlite approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophiebits @acdlite @Akshat-Jain @facebook-github-bot