-
Notifications
You must be signed in to change notification settings - Fork 47.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate legacy context within StrictMode tree #13760
Merged
bvaughn
merged 1 commit into
facebook:master
from
bvaughn:deprecate-legacy-context-in-strict-mode
Oct 3, 2018
Merged
Deprecate legacy context within StrictMode tree #13760
bvaughn
merged 1 commit into
facebook:master
from
bvaughn:deprecate-legacy-context-in-strict-mode
Oct 3, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 3c60f32...2f1ab4c react
react-dom
react-art
scheduler
Generated by 🚫 dangerJS |
Got approval from Sebastian via a Messenger message so I'm going to land this one~ |
acdlite
pushed a commit
to plievone/react
that referenced
this pull request
Oct 5, 2018
linjiajian999
pushed a commit
to linjiajian999/react
that referenced
this pull request
Oct 22, 2018
Merged
This was referenced Oct 24, 2018
This was referenced Nov 1, 2018
This was referenced Dec 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
warnAboutLegacyContextAPI
feature flag (and always warn about legacy context inside ofStrictMode
tree). Updated tests with legacy context to expect warnings.Note that I will be on PTO from Oct 4th - Oct 18th and will be unresponsive to PR feedback. All React core team members have been added as collaborators to my fork. Please feel free to make changes directly to this branch before merging.