Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dom: Update README.md #13935

Closed
wants to merge 1 commit into from
Closed

react-dom: Update README.md #13935

wants to merge 1 commit into from

Conversation

marcelometal
Copy link
Contributor

Replaced 'var' with 'const'

@marcelometal
react-dom: Updated README.md
2ef127b 
Replaced 'var' with 'const'
@klamping klamping mentioned this pull request Oct 24, 2018
Open
@marcelometal marcelometal changed the title react-dom: Updated README.md react-dom: Update README.md Oct 24, 2018
@sizebot
Copy link

sizebot commented Oct 24, 2018

Details of bundled changes.

Comparing: b5539ad...2ef127b

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@gaearon
Copy link
Collaborator

gaearon commented Nov 5, 2018

Thanks but people reading this might be using ES5 too. I don't really see the point of this, especially for a commonly used package like React itself.

@gaearon gaearon closed this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikaskyadav vikaskyadav vikaskyadav approved these changes

@maxzitron maxzitron maxzitron approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcelometal @sizebot @gaearon @maxzitron @vikaskyadav @facebook-github-bot