Warn about incorrect use of useImperativeHandle() #14647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Jan 21, 2019
| warning( | ||
| refObject.hasOwnProperty('current'), | ||
| 'Expected useImperativeHandle() first argument to either be a ' + | ||
| 'ref callback or React.createRef() object. Instead received: %s.', |
There was a problem hiding this comment.
(Note: callback is handled by previous if-clause so we don't need to check for that)
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: b5a3df6...64841ee react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
gaearon
force-pushed
the
ref-warn-hook
branch
from
ca8c97a
to
133d256
Compare
gaearon
force-pushed
the
ref-warn-hook
branch
from
133d256
to
64841ee
Compare
threepointone
approved these changes
Jan 21, 2019
gaearon
added a commit
that referenced
this pull request
Jan 21, 2019
…Mode" (#14652) * Revert "Revert "Disallow reading context during useMemo etc" (#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (#14645)" This reverts commit 2a084f5. * Revert "Fix typo (#14560)" This reverts commit b5a3df6. * Revert "fix typo (#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (#14643)" This reverts commit a1414e8.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…Mode" (facebook#14652) * Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (facebook#14645)" This reverts commit 2a084f5. * Revert "Fix typo (facebook#14560)" This reverts commit b5a3df6. * Revert "fix typo (facebook#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)" This reverts commit a1414e8.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…Mode" (facebook#14652) * Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (facebook#14645)" This reverts commit 2a084f5. * Revert "Fix typo (facebook#14560)" This reverts commit b5a3df6. * Revert "fix typo (facebook#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)" This reverts commit a1414e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14629.
I've made these mistakes quite a few times and I expect more people to do it.
This protects against:
useImperativeHandle({ focus })useImperativeHandle(ref, { focus })(Correct one is
useImperativeHandle(ref, () => ({ focus })).)While adding these warnings I also noticed we don't set current fiber during some effect traversals. This seems like a regression. It caused warnings from Hooks during commit phase to have no component stack. So I fixed that too.