Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor legacy update queue #17510

Closed
wants to merge 4 commits into from
Closed

Refactor legacy update queue #17510

wants to merge 4 commits into from

Commits on Dec 9, 2019

  1. Failing test: Updates "un-committed" when rebasing 

    Adds a failing test case where an update that was committed is
later skipped over during a rebase. This should never happen.
    @acdlite @sebmarkbage
    acdlite authored and sebmarkbage committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    474e99d View commit details
    Browse the repository at this point in the history

  2. Refactor Hooks update queue

    @sebmarkbage
    sebmarkbage committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    89ca3cf View commit details
    Browse the repository at this point in the history

  3. Add regression test for update queue bug 

    This test passes in the old legacy update queue implementation. I'm
adding this before the refactor to prevent a regression.
    @acdlite
    acdlite committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    aeee2bf View commit details
    Browse the repository at this point in the history

  4. Refactor legacy update queue 

    Refactors legacy update queue to incoporate rebasing fix. Uses nearly
the same approach as the hook update queue but has to handle a few
other cases.
    @acdlite
    acdlite committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    99444a2 View commit details
    Browse the repository at this point in the history