Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint-plugin-react-hooks] Report constant constructions #19590

Merged
merged 9 commits into from
Aug 13, 2020
Merged

[eslint-plugin-react-hooks] Report constant constructions #19590

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bc36370
[eslint-plugin-react-cooks] Report constant constructions
captbaritone Aug 11, 2020
450cdfd
Fix/remove existing tests
captbaritone Aug 12, 2020
75fcb35
Don't give an autofix of wrapping object declarations
captbaritone Aug 12, 2020
4b6e20e
Handle the long tail of nodes that will be referentially unique
captbaritone Aug 12, 2020
e0ca072
Catch let/var constant constructions on initial assignment
captbaritone Aug 13, 2020
4dc35db
Trim trailing whitespace
captbaritone Aug 13, 2020
eaa2aff
Address feedback from @gaearon
captbaritone Aug 13, 2020
2b7ae4b
Rename "assignment" to "initialization"
captbaritone Aug 13, 2020
31f75cd
Add test for a constant construction used in multiple dependency arrays
captbaritone Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading