Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new effect fields to old fork, and vice versa #20246

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Add new effect fields to old fork, and vice versa #20246

merged 2 commits into from
Nov 13, 2020

Commits on Nov 13, 2020

  1. Add new effect fields to old fork 

    So that when comparing relative performance, we don't penalize the new
fork for using more memory.
    @acdlite
    acdlite committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    2ae3590 View commit details
    Browse the repository at this point in the history

  2. Add firstEffect, et al fields to new fork 

    We need to bisect the changes to the recent commit phase refactor. To
do this, we'll need to add back the effect list temporarily.

This only adds them to the Fiber type so that the memory is the same
as the old fork.
    @acdlite
    acdlite committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    ccf2440 View commit details
    Browse the repository at this point in the history