Fix Flight Prod Fixture #20382
Merged
Fix Flight Prod Fixture #20382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Babel transpilation fails for some reason in prod.
Uses python because meh. Just to show it's static.
facebook-github-bot
added
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d96f5f3:
|
gaearon
approved these changes
Dec 5, 2020
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Don't use async/await Babel transpilation fails for some reason in prod. * Set up production runner command Uses python because meh. Just to show it's static. * Use build folder in prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is messed with Babel where it inserts a dependency on an async helper which is an ESM module. This doesn't work in modern Node from a CommonJS file so it errors before it has a chance to transpile it. I have no idea why this is only affecting prod.
The solution is just to not use async/await.
Also wired up some helper so now the prod example works.