Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if static flag is accidentally cleared #20807

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Warn if static flag is accidentally cleared #20807

merged 3 commits into from
Feb 11, 2021

Commits on Feb 11, 2021

  1. Warn if static flag is accidentally cleared 

    "Static" fiber flags are flags that are meant to exist for the lifetime
of a component. It's really important not to accidentally reset these,
because we use them to decide whether or not to perform some operation
on a tree (which we can do because they get bubbled via `subtreeFlags)`.

We've had several bugs that were caused by this mistake, so we actually
don't rely on static flags anywhere, yet. But we'd like to.

So let's roll out this warning and see if it fires anywhere. Once we
can confirm that there are no warnings, we can assume that it's safe
to start using static flags.

I did not wrap it behind a feature flag, because it's dev-only, and we
can use our internal warning filter to hide this from the console.
    @acdlite
    acdlite committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    5d25752 View commit details
    Browse the repository at this point in the history

  2. Intentionally clear static flag to test warning

    @acdlite
    acdlite committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    6e1e3df View commit details
    Browse the repository at this point in the history

  3. ...and fix it again

    @acdlite
    acdlite committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    99dc7a9 View commit details
    Browse the repository at this point in the history