Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devtools: Don't display hook index of useContext #22200

Merged
merged 2 commits into from
Aug 30, 2021
Merged

devtools: Don't display hook index of useContext #22200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f88b0fe
Illustrate behavior of useContext usage in HooksTree
eps1lon Aug 28, 2021
da6c72b
devtools: Don't display useContext with a hook index
eps1lon Aug 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ function HookView({

let name = hook.name;
if (enableProfilerChangedHookIndices) {
if (!isCustomHook) {
if (hookID !== null) {
name = (
<>
<span className={styles.PrimitiveHookNumber}>{hookID + 1}</span>
Expand Down
10 changes: 10 additions & 0 deletions packages/react-devtools-shell/src/app/InspectableElements/CustomHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@

import * as React from 'react';
import {
createContext,
forwardRef,
Fragment,
memo,
useCallback,
useContext,
useDebugValue,
useEffect,
useState,
Expand Down Expand Up @@ -64,8 +66,13 @@ function useDeepHookF() {
useDebugValue('useDeepHookF');
}

const ContextA = createContext('A');
const ContextB = createContext('B');

function FunctionWithHooks(props: any, ref: React$Ref<any>) {
const [count, updateCount] = useState(0);
// eslint-disable-next-line no-unused-vars
const contextValueA = useContext(ContextA);

// eslint-disable-next-line no-unused-vars
const [_, __] = useState(object);
Expand All @@ -85,6 +92,9 @@ function FunctionWithHooks(props: any, ref: React$Ref<any>) {
// Tests nested custom hooks
useNestedOuterHook();

// eslint-disable-next-line no-unused-vars
const contextValueB = useContext(ContextB);

// Verify deep nesting doesn't break
useDeepHookA();

Expand Down