Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createRoot/hydrateRoot to react-dom/client #23385

Merged
merged 8 commits into from
Mar 1, 2022

Commits on Feb 28, 2022

  1. Move createRoot/hydrateRoot to /client

    We want these APIs ideally to be imported separately from things you
    might use in arbitrary components (like flushSync). Those other methods
    are "isomorphic" to how the ReactDOM tree is rendered. Similar to hooks.
    
    E.g. importing flushSync into a component that only uses it on the client
    should ideally not also pull in the entry client implementation on the
    server.
    
    This also creates a nicer parity with /server where the roots are in a
    separate entry point.
    
    Unfortunately, I can't quite do this yet because we have some legacy APIs
    that we plan on removing (like findDOMNode) and we also haven't implemented
    flushSync using a flag like startTransition does yet.
    
    Another problem is that we currently encourage these APIs to be aliased by
    /profiling (or unstable_testing). In the future you don't have to alias
    them because you can just change your roots to just import those APIs and
    they'll still work with the isomorphic forms. Although we might also just
    use export conditions for them.
    
    For that all to work, I went with a different strategy for now where the
    real API is in / but it comes with a warning if you use it. If you instead
    import /client it disables the warning in a wrapper. That means that if you
    alias / then import /client that will inturn import the alias and it'll
    just work.
    
    In a future breaking changes (likely when we switch to ESM) we can just
    remove createRoot/hydrateRoot from / and move away from the aliasing
    strategy.
    sebmarkbage committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    3bc2424 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1afe55a View commit details
    Browse the repository at this point in the history
  3. Fix fixtures

    sebmarkbage committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    3fe0a5a View commit details
    Browse the repository at this point in the history
  4. Update warnings

    sebmarkbage committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    abc6824 View commit details
    Browse the repository at this point in the history
  5. Add test for the warning

    sebmarkbage committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    ecedff2 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Update devtools

    sebmarkbage committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c95aabf View commit details
    Browse the repository at this point in the history
  2. Change order of react-dom, react-dom/client alias

    I think the order matters here. The first one takes precedence.
    acdlite authored and sebmarkbage committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    29e7b0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f403f13 View commit details
    Browse the repository at this point in the history