Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React DevTools 4.24.3 -> 4.24.4 #24315

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 8, 2022

If there's no objection, I'd like to publish these two bug fixes to NPM! (I'd offer to post to Chrome/Firefox/Edge as well but I no longer have access.)

I've ran the scripts/devtools/build-and-test.js script locally to spot check these changes.

If you'd rather wait to release, that's no problem– feel free to just close this PR. 😄

@lunaruan
Copy link
Contributor

lunaruan commented Apr 8, 2022

We can release, but as a heads up, I'll be offline from April 18-29, and @mondaychen will be offline from April 18-22. If you're okay with helping us monitor for issues during those weeks feel free to release! 😃

Copy link
Contributor

@lunaruan lunaruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bribing you with this 😂

@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 8, 2022

Sure. Happy to keep an eye on things. (I scan issues already.)

Just to confirm then: You want to run the NPM release yourself? I don't mind doing it (but I'm also happy to defer if you'd prefer.)

@bvaughn bvaughn merged commit 5b2e725 into facebook:main Apr 8, 2022
@bvaughn bvaughn deleted the devtools-4_24_4 branch April 8, 2022 15:38
@lunaruan
Copy link
Contributor

lunaruan commented Apr 8, 2022

naw do ittttt

@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 8, 2022

Done.

Thanks for the review!

rickhanlonii pushed a commit that referenced this pull request Apr 13, 2022
rickhanlonii pushed a commit that referenced this pull request Apr 14, 2022
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants