use-sync-external-store: Add `exports` field to `package.json` #25231

eps1lon · 2022-09-10T12:15:44Z

Summary

Alternate to #24440. I needed a CI build to test the published package

How did you test this change?

CI

Testing all entrypoints https://github.com/eps1lon/react-pr-25231-uses-exports-field-test

import A from "use-sync-external-store"
import B from "use-sync-external-store/with-selector"
import C from "use-sync-external-store/shim"
import D from "use-sync-external-store/shim/index.native"
import E from "use-sync-external-store/shim/with-selector"
import F from "use-sync-external-store/package.json" assert { type: "json" };

sizebot · 2022-09-10T12:20:51Z

Comparing: 1e3e30d...360fe3d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	153.65 kB	153.65 kB	=	48.90 kB	48.90 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	155.57 kB	155.57 kB	=	49.51 kB	49.51 kB
facebook-www/ReactDOM-prod.classic.js	=	530.46 kB	530.46 kB	=	94.67 kB	94.67 kB
facebook-www/ReactDOM-prod.modern.js	=	515.71 kB	515.71 kB	=	92.49 kB	92.49 kB
facebook-www/ReactDOMForked-prod.classic.js	=	530.46 kB	530.46 kB	=	94.67 kB	94.67 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 360fe3d

eps1lon · 2022-09-10T12:47:17Z

packages/use-sync-external-store/package.json

+      "react-native": "./shim/index.native.js",
+      "default": "./shim/index.js"
+    },
+    "./shim/index.native": "./shim/index.native.js",


For compat with bundlers that don't support the react-native condition. Though I don't know if we need it. I just copied it from #24440

https://github.com/facebook/react/blob/main/packages/use-sync-external-store/src/__tests__/useSyncExternalStoreNative-test.js#L45
It seems that this entry has been used in several places. I'm not sure if this is necessary.

Andarist · 2022-09-13T14:05:06Z

packages/use-sync-external-store/src/useSyncExternalStoreWithSelector.js

@@ -9,7 +9,7 @@

 import * as React from 'react';
 import is from 'shared/objectIs';
-import {useSyncExternalStore} from 'use-sync-external-store/src/useSyncExternalStore';
+import {useSyncExternalStore} from './useSyncExternalStore';


Perhaps a similar change should be done in other places to at least match the style?

What other places?

Like here:

react/packages/use-sync-external-store/with-selector.js

Line 12 in 62a5371

export {useSyncExternalStoreWithSelector} from 'use-sync-external-store/src/useSyncExternalStoreWithSelector';

These are entrypoints so I'm not sure they should change. This PR is green and tested and I personally don't want make stylistic changes that invalidates all of that unless it's required to get this merged.

This should fail IMHO since there are no "./src/*" exports in package.json.

Since the src exports will get removed at the publish stage, it might be a good idea to add it back for local development.

This should fail IMHO since there are no "./src/*" exports in package.json.

react/packages/use-sync-external-store/with-selector.js is fed to rollup and will not be shipped with the src/ path. I would suggest checking out the repository that was used for testing to see how files look after bundling.

github-actions · 2024-04-10T01:24:16Z

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

TkDodo · 2024-04-10T07:03:52Z

bump

github-actions · 2024-07-09T23:05:28Z

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

latin-1 · 2024-07-10T07:39:27Z

Bump

github-actions · 2024-10-08T09:05:09Z

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

markerikson · 2024-10-09T00:55:47Z

VERY NOT STALE

HansBrende · 2024-11-20T18:54:26Z

@eps1lon could you perhaps edit the PR description to include "Fixes #24590" so that that issue links to this PR along with the other PR it currently links to? Or is that PR preferable and this one should be closed in that case?

facebook-github-bot added the CLA Signed label Sep 10, 2022

eps1lon force-pushed the feat/uSES-export branch from 8cd5c8c to 3cf0eb2 Compare September 10, 2022 12:35

eps1lon changed the title ~~use-sync-external-store: Add exports field to package.json~~ use-sync-external-store: Add exports field to package.json Sep 10, 2022

eps1lon force-pushed the feat/uSES-export branch from 3cf0eb2 to 62a5371 Compare September 10, 2022 12:45

eps1lon commented Sep 10, 2022

View reviewed changes

eps1lon marked this pull request as ready for review September 10, 2022 12:56

eps1lon mentioned this pull request Sep 10, 2022

Add "exports" field to use-sync-external-store's package.json #24440

Closed

TkDodo mentioned this pull request Sep 12, 2022

@tanstack/[email protected] react-native example does not work - queryFn not being called TanStack/query#4154

Closed

Andarist reviewed Sep 13, 2022

View reviewed changes

use-sync-external-store: Add exports field to package.json

360fe3d

eps1lon force-pushed the feat/uSES-export branch from 62a5371 to 360fe3d Compare November 9, 2022 19:41

This was referenced Jan 6, 2023

Fix use-sync-external-store import for Webpack 5 molefrog/wouter#276

Merged

React Native: Queries not executing on v4 TanStack/query#3582

Closed

undoZen mentioned this pull request Jan 9, 2023

remesh4.0.0更新使用react useSyncExternalStore，导致无法正常使用remesh包。 remesh-js/remesh#71

Closed

eps1lon mentioned this pull request Feb 25, 2023

Add package.json exports for use-sync-external-store #26230

Open

github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024

github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024

HansBrende mentioned this pull request Apr 19, 2024

Bug: Support ESM for the use-sync-external-store shim #24590

Open

phryneas mentioned this pull request Jun 20, 2024

adds "rehackt/use-sync-external-store-shim" phryneas/rehackt#12

Open

github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Jul 9, 2024

github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Jul 10, 2024

timdorr mentioned this pull request Jul 29, 2024

Native ESM import problem 'with use-sync-external-store' reduxjs/react-redux#2191

Closed

1 task

github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Oct 8, 2024

github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Oct 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use-sync-external-store: Add `exports` field to `package.json` #25231

use-sync-external-store: Add `exports` field to `package.json` #25231

eps1lon commented Sep 10, 2022 •

edited

Loading

sizebot commented Sep 10, 2022 •

edited

Loading

eps1lon Sep 10, 2022

latin-1 Sep 11, 2022

Andarist Sep 13, 2022

eps1lon Sep 13, 2022

Andarist Sep 13, 2022

eps1lon Sep 13, 2022

latin-1 Sep 14, 2022

latin-1 Sep 14, 2022

latin-1 Sep 14, 2022

eps1lon Sep 15, 2022

github-actions bot commented Apr 10, 2024

TkDodo commented Apr 10, 2024

github-actions bot commented Jul 9, 2024

latin-1 commented Jul 10, 2024

github-actions bot commented Oct 8, 2024

markerikson commented Oct 9, 2024

HansBrende commented Nov 20, 2024

use-sync-external-store: Add exports field to package.json #25231

Are you sure you want to change the base?

use-sync-external-store: Add exports field to package.json #25231

Conversation

eps1lon commented Sep 10, 2022 • edited Loading

Summary

How did you test this change?

sizebot commented Sep 10, 2022 • edited Loading

Critical size changes

Significant size changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 10, 2024

TkDodo commented Apr 10, 2024

github-actions bot commented Jul 9, 2024

latin-1 commented Jul 10, 2024

github-actions bot commented Oct 8, 2024

markerikson commented Oct 9, 2024

HansBrende commented Nov 20, 2024

use-sync-external-store: Add `exports` field to `package.json` #25231

use-sync-external-store: Add `exports` field to `package.json` #25231

eps1lon commented Sep 10, 2022 •

edited

Loading

sizebot commented Sep 10, 2022 •

edited

Loading