[Fizz] Add failing test for failed hydration when using uSES in StrictMode #26113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
commented
Feb 6, 2023
Comment on lines
2381
to
2386
| expect(Scheduler).toFlushAndYield([ | ||
| 'Nay!', | ||
| // Missing flushAndYield | ||
| // 'Yay!' | ||
| ]); | ||
| }).toErrorDev([]); |
There was a problem hiding this comment.
Without StrictMode it doesn't error.
|
Comparing: b600620...b37bce4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This comment was marked as spam.
This comment was marked as spam.
eps1lon
force-pushed
the
test/strict-uses-hydration
branch
from
e5823a1 to
eb4a9f4
Compare
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Apr 16, 2023
eps1lon
force-pushed
the
test/strict-uses-hydration
branch
from
eb4a9f4 to
443ceca
Compare
eps1lon
force-pushed
the
test/strict-uses-hydration
branch
from
443ceca to
b37bce4
Compare
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
May 7, 2023
Previously, we'd call and use getSnapshot on the second render resulting in `Warning: Text content did not match. Server: "Nay!" Client: "Yay!"` and then `Error: Text content does not match server-rendered HTML.`. Fixes facebook#26095. Closes facebook#26113.
sophiebits
added a commit
that referenced
this pull request
May 12, 2023
Previously, we'd call and use getSnapshot on the second render resulting in `Warning: Text content did not match. Server: "Nay!" Client: "Yay!"` and then `Error: Text content does not match server-rendered HTML.`. Fixes #26095. Closes #26113. Closes #25650. --------- Co-authored-by: eps1lon <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 12, 2023
Previously, we'd call and use getSnapshot on the second render resulting in `Warning: Text content did not match. Server: "Nay!" Client: "Yay!"` and then `Error: Text content does not match server-rendered HTML.`. Fixes #26095. Closes #26113. Closes #25650. --------- Co-authored-by: eps1lon <[email protected]> DiffTrain build for [4cd7065](4cd7065)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Previously, we'd call and use getSnapshot on the second render resulting in `Warning: Text content did not match. Server: "Nay!" Client: "Yay!"` and then `Error: Text content does not match server-rendered HTML.`. Fixes facebook#26095. Closes facebook#26113. Closes facebook#25650. --------- Co-authored-by: eps1lon <[email protected]>
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Previously, we'd call and use getSnapshot on the second render resulting in `Warning: Text content did not match. Server: "Nay!" Client: "Yay!"` and then `Error: Text content does not match server-rendered HTML.`. Fixes #26095. Closes #26113. Closes #25650. --------- Co-authored-by: eps1lon <[email protected]> DiffTrain build for commit 4cd7065.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Failing test for #26095
How did you test this change?
yarn test ReactDOMFizzServer-test