Added note for proper example display #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsfiddles weren't showing up for me. Upon further investigation I found that changing to http fixes the embedding.
|
I like it. Another idea is to let the iframe link to a new page at facebook.github.io. On that page a script could look at the protocol: For http redirect to jsfiddle and for https write an error message into the iframe. But your solution would be simpler. |
|
Yea, this seems like a fine way to address the problem. Thanks! |
zpao
added a commit
that referenced
this pull request
Dec 18, 2014
Added note for proper example display
zpao
added a commit
that referenced
this pull request
Jan 17, 2015
Added note for proper example display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsfiddles weren't showing up for me. Upon further investigation I found that changing to http fixes the embedding.