fix(eslint-plugin-react-hooks): accepting `as` expression as a callback #28202

StyleShit · 2024-02-01T19:52:00Z

Summary

Closes #20750

How did you test this change?

Added a test case

Closes facebook#20750

react-sizebot · 2024-02-01T19:56:22Z

Comparing: a1433ca...e0b608c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.22%	92.49 kB	92.69 kB	+0.06%	21.77 kB	21.79 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.22%	92.49 kB	92.69 kB	+0.06%	21.77 kB	21.79 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.21%	92.63 kB	92.83 kB	+0.06%	21.80 kB	21.81 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.21%	93.46 kB	93.66 kB	+0.06%	21.97 kB	21.98 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.21%	93.46 kB	93.66 kB	+0.06%	21.97 kB	21.98 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.21%	93.61 kB	93.81 kB	+0.06%	21.99 kB	22.01 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against e0b608c

eps1lon

Thanks

…ck (#28202) ## Summary Closes #20750 ## How did you test this change? Added a test case DiffTrain build for [2efa383](2efa383)

…ck (#28202) ## Summary Closes #20750 ## How did you test this change? Added a test case

…ck (facebook#28202) ## Summary Closes facebook#20750 ## How did you test this change? Added a test case

…ck (#28202) ## Summary Closes #20750 ## How did you test this change? Added a test case DiffTrain build for commit 2efa383.

@kassens

##### [v5.0.0](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#500) - **New Violations:** Component names now need to start with an uppercase letter instead of a non-lowercase letter. This means `_Button` or `_component` are no longer valid. ([@kassens](https://github.com/kassens)) in [#25162](facebook/react#25162)  - Consider dispatch from `useActionState` stable. ([@eps1lon](https://github.com/eps1lon) in [#29665](facebook/react#29665)) - Add support for ESLint v9. ([@eps1lon](https://github.com/eps1lon) in [#28773](facebook/react#28773)) - Accept `as` expression in callback. ([@StyleShit](https://github.com/StyleShit) in [#28202](facebook/react#28202)) - Accept `as` expressions in deps array. ([@StyleShit](https://github.com/StyleShit) in [#28189](facebook/react#28189)) - Treat `React.use()` the same as `use()`. ([@kassens](https://github.com/kassens) in [#27769](facebook/react#27769)) - Move `use()` lint to non-experimental. ([@kassens](https://github.com/kassens) in [#27768](facebook/react#27768)) - Support Flow `as` expressions. ([@cpojer](https://github.com/cpojer) in [#27590](facebook/react#27590)) - Allow `useEffect(fn, undefined)`. ([@kassens](https://github.com/kassens) in [#27525](facebook/react#27525)) - Disallow hooks in async functions. ([@acdlite](https://github.com/acdlite) in [#27045](facebook/react#27045)) - Rename experimental `useEvent` to `useEffectEvent`. ([@sebmarkbage](https://github.com/sebmarkbage) in [#25881](facebook/react#25881)) - Lint for presence of `useEvent` functions in dependency lists. ([@poteto](https://github.com/poteto) in [#25512](facebook/react#25512)) - Check `useEvent` references instead. ([@poteto](https://github.com/poteto) in [#25319](facebook/react#25319)) - Update `RulesOfHooks` with `useEvent` rules. ([@poteto](https://github.com/poteto) in [#25285](facebook/react#25285))

fix(eslint-plugin-react-hooks): accepting as expression as a callback

e0b608c

Closes facebook#20750

facebook-github-bot added the CLA Signed label Feb 1, 2024

eps1lon approved these changes Feb 1, 2024

View reviewed changes

eps1lon merged commit 2efa383 into facebook:main Feb 1, 2024
36 checks passed

github-actions bot pushed a commit that referenced this pull request Feb 1, 2024

fix(eslint-plugin-react-hooks): accepting as expression as a callba…

65f2fcf

…ck (#28202) ## Summary Closes #20750 ## How did you test this change? Added a test case DiffTrain build for [2efa383](2efa383)

gaearon pushed a commit that referenced this pull request Feb 3, 2024

fix(eslint-plugin-react-hooks): accepting as expression as a callba…

9177938

…ck (#28202) ## Summary Closes #20750 ## How did you test this change? Added a test case

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

fix(eslint-plugin-react-hooks): accepting as expression as a callba…

1917560

…ck (facebook#28202) ## Summary Closes facebook#20750 ## How did you test this change? Added a test case

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

fix(eslint-plugin-react-hooks): accepting as expression as a callba…

32584c1

…ck (#28202) ## Summary Closes #20750 ## How did you test this change? Added a test case DiffTrain build for commit 2efa383.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin-react-hooks): accepting `as` expression as a callback #28202

fix(eslint-plugin-react-hooks): accepting `as` expression as a callback #28202

StyleShit commented Feb 1, 2024

react-sizebot commented Feb 1, 2024

eps1lon left a comment

fix(eslint-plugin-react-hooks): accepting as expression as a callback #28202

fix(eslint-plugin-react-hooks): accepting as expression as a callback #28202

Conversation

StyleShit commented Feb 1, 2024

Summary

How did you test this change?

react-sizebot commented Feb 1, 2024

Critical size changes

Significant size changes

eps1lon left a comment

Choose a reason for hiding this comment

fix(eslint-plugin-react-hooks): accepting `as` expression as a callback #28202

fix(eslint-plugin-react-hooks): accepting `as` expression as a callback #28202