Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: support useEffectEvent and forward-fix experimental prefix support #32106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Jan 17, 2025

  • Adds support for experimental_useEffectEvent, now DevTools will be able to display this hook for inspected element
  • Added a use case to DevTools shell, couldn't add case, because we are using ReactTestRenderer, which has the corresponding flag disabled.
  • Forward-fix logic for handling experimental prefix that was added in fix[DevTools]: support useResourceEffect #32088.

Screenshot 2025-01-16 at 21 24 12

@react-sizebot
Copy link

react-sizebot commented Jan 17, 2025

Comparing: 61e713c...7d38eb0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.73 kB 91.74 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 556.18 kB = 98.72 kB 98.72 kB
facebook-www/ReactDOM-prod.classic.js = 595.79 kB 595.79 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 586.21 kB 586.21 kB = 103.30 kB 103.30 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js +2.01% 28.15 kB 28.72 kB +1.29% 5.56 kB 5.64 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js +2.01% 28.15 kB 28.72 kB +1.29% 5.56 kB 5.64 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js +2.01% 28.15 kB 28.72 kB +1.29% 5.56 kB 5.64 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +2.01% 31.60 kB 32.24 kB +1.25% 5.69 kB 5.77 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +2.01% 31.60 kB 32.24 kB +1.25% 5.69 kB 5.77 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +2.01% 31.60 kB 32.24 kB +1.25% 5.69 kB 5.77 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 84.50 kB 80.38 kB = 14.98 kB 14.63 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 82.55 kB 78.52 kB = 14.71 kB 14.37 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 82.55 kB 78.52 kB = 14.71 kB 14.37 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 92.39 kB 87.86 kB = 15.08 kB 14.73 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 92.39 kB 87.86 kB = 15.08 kB 14.73 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 94.58 kB 89.94 kB = 15.33 kB 14.97 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js +2.01% 28.15 kB 28.72 kB +1.29% 5.56 kB 5.64 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js +2.01% 28.15 kB 28.72 kB +1.29% 5.56 kB 5.64 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js +2.01% 28.15 kB 28.72 kB +1.29% 5.56 kB 5.64 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +2.01% 31.60 kB 32.24 kB +1.25% 5.69 kB 5.77 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +2.01% 31.60 kB 32.24 kB +1.25% 5.69 kB 5.77 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +2.01% 31.60 kB 32.24 kB +1.25% 5.69 kB 5.77 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 84.50 kB 80.38 kB = 14.98 kB 14.63 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 82.55 kB 78.52 kB = 14.71 kB 14.37 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 82.55 kB 78.52 kB = 14.71 kB 14.37 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 92.39 kB 87.86 kB = 15.08 kB 14.73 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 92.39 kB 87.86 kB = 15.08 kB 14.73 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 94.58 kB 89.94 kB = 15.33 kB 14.97 kB

Generated by 🚫 dangerJS against 7839842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants