Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't blow up on missing _store in element validation #4975

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Don't blow up on missing _store in element validation #4975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/isomorphic/classic/element/ReactElementValidator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ var loggedTypeFailures = {};
* @param {*} parentType element's parent's type.
*/
function validateExplicitKey(element, parentType) {
if (element._store.validated || element.key != null) {
if (!element._store || element._store.validated || element.key != null) {
return;
}
element._store.validated = true;
Expand Down
16 changes: 16 additions & 0 deletions src/isomorphic/classic/element/__tests__/ReactElementValidator-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,4 +467,20 @@ describe('ReactElementValidator', function() {
}
});

it('does not blow up with inlined children', function() {
// We don't suggest this since it silences all sorts of warnings, but we
// shouldn't blow up either.

var child = {
$$typeof: (<div />).$$typeof,
type: 'span',
key: null,
ref: null,
props: {},
_owner: null,
};

void <div>{[child]}</div>;
});

});