#6871 - Add not dev warning for ReactPerf & remove dev checking for ReactDebugTool method #6884

sashashakun · 2016-05-26T07:08:28Z

Steps before PR:

1. Fork the repo and create your branch from master.
2. If you've added code that should be tested, add tests!
3. If you've changed APIs, update the documentation. - need to investigate
4. Ensure the test suite passes (grunt test).
5. Make sure your code lints (grunt lint) - we've done our best to make sure these rules match our internal linting guidelines.
6. If you haven't already, complete the CLA.

…gTool.GetFlushHistory

sashashakun · 2016-05-26T08:14:11Z

Hmm, found some problem. I tryed to avoid copy pasting the same code at the beginnig of every method in ReactPerf and make helper returnWarnIfDevFalse for

Add warnings and early returns to all methods in ReactPerf when DEV is false

but now helper will be executed and independently of it's result, other part of method will be executed too. Need help for good solution here.

gaearon · 2016-05-26T18:53:30Z

src/renderers/shared/ReactPerf.js


 function roundFloat(val, base = 2) {
  var n = Math.pow(10, base);
  return Math.floor(val * n) / n;
 }

+function returnWarnIfDevFalse(returningValue = 0) {


Let’s call it warnInProduction.

ghost · 2016-05-26T19:22:20Z

@sashashakun updated the pull request.

sashashakun · 2016-05-26T19:25:35Z

Also, should I squash commits before PR will be merged or github do it in right way?

gaearon · 2016-05-26T19:38:12Z

I’ll squash when this is ready, GitHub now lets it be done via UI.

gaearon · 2016-05-26T19:38:50Z

src/renderers/shared/ReactPerf.js

@@ -19,11 +19,28 @@ function roundFloat(val, base = 2) {
  return Math.floor(val * n) / n;
 }

+function warnInProduction() {
+  if (typeof console !== 'undefined') {
+    console.error('ReactPerf is not supported in the production builds of React.' +


Nitpick: let’s start string literal from the next line.

console.error( 'ga ga ' + 'o la la' );

ghost · 2016-05-26T19:46:46Z

@sashashakun updated the pull request.

ghost · 2016-05-26T20:03:55Z

@sashashakun updated the pull request.

ghost · 2016-05-26T20:23:57Z

@sashashakun updated the pull request.

facebook-github-bot · 2016-05-28T07:02:15Z

@sashashakun updated the pull request.

sashashakun · 2016-05-28T07:04:06Z

Let's also add a test similar to ReactDOMProduction in its setup so we don't break it again.
Got it. Will start ASAP.

Also, have some problem with test in travis, but don't have problems with local tests.

P.S. I am afraid that do this PR too long

gaearon · 2016-05-28T15:04:40Z

Also, have some problem with test in travis, but don't have problems with local tests.

Try to merge master into your branch and check if something fails locally.

P.S. I am afraid that do this PR too long

I’ve been doing the ReactPerf PR for two months so it’s not long. 😉
Take your time.

sashashakun · 2016-05-30T19:04:37Z

Hmm, merge master branch from facebook/react to local and after that to react-perf-warnings-changes branch from sashashakun/react and that's it, no problem. Need not to forget in future update branch before new push)
Starting to write tests for this😌

ghost · 2016-05-30T19:10:16Z

@sashashakun updated the pull request.

ghost · 2016-06-04T14:17:49Z

@sashashakun updated the pull request.

gaearon · 2016-06-04T15:10:14Z

src/renderers/shared/__tests__/ReactPerf-test.js

+    spyOn(console, 'error');
+
+    expect(ReactPerf.getLastMeasurements()).toEqual([]);
+


Let’s remove the blank lines here, they don’t help much.

ghost · 2016-06-04T17:13:25Z

@sashashakun updated the pull request.

Fixes #6871

, #6975)" This reverts commit f71dfbc. Reverting because GitHub stripped the original PR author.

gaearon · 2016-06-06T18:54:48Z

A little recap in case it’s confusing what happened here:

I created a separate PR because I wanted to make a small change here.
I pressed Squash & Merge there without realizing GitHub would erase the original author.
I reverted that commit because I wanted to preserve the author.
I squashed & merged this PR instead.
I submitted my style change in a separate PR in Tweak ReactPerf warning message and code style #6977.

Sorry about this mess. 😓

@sashashakun Thanks for this! Sorry it took so long to review.

sashashakun · 2016-06-06T19:02:13Z

@gaearon no problem, I understand 😌 thanks for help!👍

) Fixes facebook#6871 (cherry picked from commit 2a46103)

Fixes #6871 (cherry picked from commit 2a46103)

add not dev warning for ReactPerf & remove dev checking for ReactDebu…

64412a0

…gTool.GetFlushHistory

ghost added GH Review: review-needed CLA Signed labels May 26, 2016

gaearon reviewed May 26, 2016
View reviewed changes

gaearon added GH Review: needs-revision and removed GH Review: review-needed labels May 26, 2016

move from warn to console.error & add explicitly returns

878a99f

ghost added GH Review: review-needed and removed GH Review: needs-revision labels May 26, 2016

fix linter errors

2840d5e

gaearon reviewed May 26, 2016
View reviewed changes

gaearon added GH Review: needs-revision and removed GH Review: review-needed labels May 26, 2016

ghost added GH Review: review-needed and removed GH Review: needs-revision labels May 26, 2016

more fixes after review

33ae3f6

roll back alreadyWarned variable and its changes

25b0810

Merge branch 'master' into react-perf-warnings-changes

499d822

add tests and fix bug in solution

497d94b

gaearon reviewed Jun 4, 2016
View reviewed changes

after review fixes

2116205

gaearon mentioned this pull request Jun 6, 2016

Warn that ReactPerf does not work in the production build #6975

Merged

gaearon added a commit that referenced this pull request Jun 6, 2016

Warn that ReactPerf does not work in the production build (#6884, #6975)

f71dfbc

Fixes #6871

gaearon added a commit that referenced this pull request Jun 6, 2016

Revert "Warn that ReactPerf does not work in the production build (#6884

afe4837

, #6975)" This reverts commit f71dfbc. Reverting because GitHub stripped the original PR author.

gaearon merged commit 2a46103 into facebook:master Jun 6, 2016

gaearon mentioned this pull request Jun 6, 2016

Tweak ReactPerf warning message and code style #6977

Merged

gaearon added GH Review: accepted and removed GH Review: review-needed labels Jun 6, 2016

zpao added this to the 15-next milestone Jun 6, 2016

zpao pushed a commit to zpao/react that referenced this pull request Jun 8, 2016

Warn that ReactPerf does not work in the production build (facebook#6884

1a2c756

) Fixes facebook#6871 (cherry picked from commit 2a46103)

zpao pushed a commit that referenced this pull request Jun 14, 2016

Warn that ReactPerf does not work in the production build (#6884)

85fd90d

Fixes #6871 (cherry picked from commit 2a46103)

zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016

sashashakun mentioned this pull request Dec 8, 2016

Which knowledge i should prepare when I want to contribute to react project? kentcdodds/ama#215

Closed

renovate bot mentioned this pull request Feb 2, 2018

Update dependency react to v0.14.9 - autoclosed signavio/backbone-rel#29

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#6871 - Add not dev warning for ReactPerf & remove dev checking for ReactDebugTool method #6884

#6871 - Add not dev warning for ReactPerf & remove dev checking for ReactDebugTool method #6884

sashashakun commented May 26, 2016 •

edited

Loading

sashashakun commented May 26, 2016 •

edited

Loading

gaearon May 26, 2016

ghost commented May 26, 2016

sashashakun commented May 26, 2016

gaearon commented May 26, 2016

gaearon May 26, 2016

ghost commented May 26, 2016

ghost commented May 26, 2016

ghost commented May 26, 2016

facebook-github-bot commented May 28, 2016

sashashakun commented May 28, 2016

gaearon commented May 28, 2016

sashashakun commented May 30, 2016

ghost commented May 30, 2016

ghost commented Jun 4, 2016

gaearon Jun 4, 2016

ghost commented Jun 4, 2016

gaearon commented Jun 6, 2016

sashashakun commented Jun 6, 2016

		spyOn(console, 'error');

		expect(ReactPerf.getLastMeasurements()).toEqual([]);

#6871 - Add not dev warning for ReactPerf & remove dev checking for ReactDebugTool method #6884

#6871 - Add not dev warning for ReactPerf & remove dev checking for ReactDebugTool method #6884

Conversation

sashashakun commented May 26, 2016 • edited Loading

sashashakun commented May 26, 2016 • edited Loading

gaearon May 26, 2016

Choose a reason for hiding this comment

ghost commented May 26, 2016

sashashakun commented May 26, 2016

gaearon commented May 26, 2016

gaearon May 26, 2016

Choose a reason for hiding this comment

ghost commented May 26, 2016

ghost commented May 26, 2016

ghost commented May 26, 2016

facebook-github-bot commented May 28, 2016

sashashakun commented May 28, 2016

gaearon commented May 28, 2016

sashashakun commented May 30, 2016

ghost commented May 30, 2016

ghost commented Jun 4, 2016

gaearon Jun 4, 2016

Choose a reason for hiding this comment

ghost commented Jun 4, 2016

gaearon commented Jun 6, 2016

sashashakun commented Jun 6, 2016

sashashakun commented May 26, 2016 •

edited

Loading

sashashakun commented May 26, 2016 •

edited

Loading