Revise ResponderTouchHistoryStore Error Handling #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| touchRecord.currentTimeStamp = timestampForTouch(touch); | ||
| touchHistory.mostRecentTimeStamp = timestampForTouch(touch); | ||
| } else { | ||
| console.error( |
There was a problem hiding this comment.
Might be a little easier to read as an early return case before the main logic.
|
I think this seems fine, sorry for delay reviewing. |
zpao
pushed a commit
that referenced
this pull request
Jul 8, 2016
Touch behavior is inconsistent across different platforms, and ResponderTouchHistoryStore currently fatals when assumptions are broken. In addition, the behavior differs between development and production. This pull request does a few things to make ResponderTouchHistoryStore easier to deal with: Adds Flow to keep the TouchEvent, Touch, and TouchRecord types straight. Changes behavior to be consistent across environments. This means either always throwing or never throwing (and making use of warning and console.error as appropriate). When an orphaned move or end event is received, print debug information and ignore it instead of crashing and burning. (cherry picked from commit 2b226f5)
usmanajmal
pushed a commit
to usmanajmal/react
that referenced
this pull request
Jul 11, 2016
Touch behavior is inconsistent across different platforms, and ResponderTouchHistoryStore currently fatals when assumptions are broken. In addition, the behavior differs between development and production. This pull request does a few things to make ResponderTouchHistoryStore easier to deal with: Adds Flow to keep the TouchEvent, Touch, and TouchRecord types straight. Changes behavior to be consistent across environments. This means either always throwing or never throwing (and making use of warning and console.error as appropriate). When an orphaned move or end event is received, print debug information and ignore it instead of crashing and burning.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touch behavior is inconsistent across different platforms, and
ResponderTouchHistoryStorecurrently fatals when assumptions are broken. In addition, the behavior differs between development and production.This pull request does a few things to make
ResponderTouchHistoryStoreeasier to deal with:TouchEvent,Touch, andTouchRecordtypes straight.warningandconsole.erroras appropriate).Reviewers: @spicyj
Test Plan:
Ran
grunt testandflow ./srcsuccessfully.Verified touch gestures continue to work in production apps.