Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid "Member not found" error in IE #7411

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Avoid "Member not found" error in IE #7411

merged 1 commit into from
Aug 19, 2016

Conversation

gmp
Copy link

@gmp gmp commented Aug 3, 2016

Explanation, discussion, and similar change as #7343

Addresses #7320

@ghost
Copy link

ghost commented Aug 3, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Aug 3, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Aug 3, 2016
@gmp gmp force-pushed the gp-ie10-event-prevent-default branch from b7e2ea7 to f72e7f2 Compare August 12, 2016 16:11
@gmp
Avoid "Member not found" error in IE
9560eda 
Explanation, discussion, and similar change as facebook#7343

Addresses facebook#7320
@gmp gmp force-pushed the gp-ie10-event-prevent-default branch from f72e7f2 to 9560eda Compare August 12, 2016 16:16
@ghost ghost added the CLA Signed label Aug 12, 2016
@gmp
Copy link
Author

gmp commented Aug 19, 2016

Don't mean to bug you guys and apologies in advance if I am, but is there anything I specifically need to do to get this reviewed?

@aweary
Copy link
Contributor

aweary commented Aug 19, 2016

@g-palmer hey, we appreciate being bugged here and there. It's easy for stuff to fall through the cracks, so thanks for the reminder.

This seems like a good and safe change 👍 thanks!

@aweary aweary added this to the 15-next milestone Aug 19, 2016
@aweary aweary merged commit a874196 into facebook:master Aug 19, 2016
@gaearon
Copy link
Collaborator

gaearon commented Aug 19, 2016

Would be nice to add an explanatory comment linking to the issue everywhere we do this.

@gmp
Copy link
Author

gmp commented Aug 19, 2016

Sure thing. Would it make sense if I just updated this same branch with the additional comment(s) and opened a new PR? Or do you prefer a new branch as well as a new PR?

@gaearon
Copy link
Collaborator

gaearon commented Aug 19, 2016

Since this is already merged I think new branch would make more sense.

@zpao zpao modified the milestones: 15.3.2, 15-next Sep 8, 2016
zpao pushed a commit that referenced this pull request Sep 15, 2016
@zpao
Avoid "Member not found" error in IE (#7411)
08dbefe 
Explanation, discussion, and similar change as #7343

Addresses #7320
(cherry picked from commit a874196)
@nhunzaker nhunzaker mentioned this pull request Mar 25, 2017
Closed
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Component: DOM
Projects
None yet
Milestone
15.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@gmp @aweary @gaearon @zpao