Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'as' keyword (#7543) #7582

Merged
merged 3 commits into from
Aug 30, 2016
Merged

Add 'as' keyword (#7543) #7582

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5750073
Add 'as' keyword (#7543)
Aug 26, 2016
a687e1b
fix commenting to adhere to styling
kevinslin Aug 28, 2016
0b53f8d
fix grammar in comment
Aug 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/renderers/dom/shared/HTMLDOMPropertyConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ var HTMLDOMPropertyConfig = {
allowFullScreen: HAS_BOOLEAN_VALUE,
allowTransparency: 0,
alt: 0,
// 'as' is keyword to links with 'preload' type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing: I think the grammar might be a little bit confusing as-is. Can we change this to:

// specifies target context for links with `preload` type

That's more in line with how the spec describes it as well. After that I think we can merge 👍

as: 0,
async: HAS_BOOLEAN_VALUE,
autoComplete: 0,
// autoFocus is polyfilled/normalized by AutoFocusUtils
Expand Down