Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass prevContext param to componentDidUpdate #8631

Merged
merged 4 commits into from
Apr 21, 2017

Commits on Mar 1, 2017

  1. Pass prevContext param to componentDidUpdate

    This makes use of an expando property (__reactInternalPrevContext) on the stateNode (instance). A property on the instance was used instead of a Fiber attribute because:
    1) Conditional fields on fibers would break monomorphism.
    2) Adding to all fibers would bloat types that don't use context.
    Brian Vaughn committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    c840fa4 View commit details
    Browse the repository at this point in the history
  2. Deprecated prevContext parameter to componentDidUpdate

    This affects Stack and Fiber. I've updated impacted tests as well.
    This may not be the direction we choose to go either. More discussion is still needed about the future of context...
    Brian Vaughn committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    cdb2aa0 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2017

  1. Merged master and resolved conflicts

    Brian Vaughn committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    e11300a View commit details
    Browse the repository at this point in the history
  2. Removed unused ReactDOMFeatureFlags variable

    Brian Vaughn committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    d0fffd7 View commit details
    Browse the repository at this point in the history