Hello 15.6 Release Candidate #9828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** We update the versions of all associated React packages when bumping the version of React. **why make this change?:** We want to publish a RC to give folks time to try out the latest version before it's final. Why bump the version of every other associated package? It makes the dependency between them more clear. There will be cases where we make a fix in React-DOM and it requires changes in React core. In that case, it will be more clear to people when we update the versions of both and they remain in sync. **test plan:** Visual inspection **issue:** facebook#9398
**what is the change?:** Updates version for 'react-dom-factories' package and 'react-addons' template. **why make this change?:** We missed these in the previous commit, which was copying the approach from https://github.com/facebook/react/pull/9828/files **test plan:** Visual inspection, and running the build **issue:** facebook#9398
|
|
bvaughn
approved these changes
Jun 1, 2017
flarnie
added a commit
to flarnie/react
that referenced
this pull request
Jun 7, 2017
* Hello 15.6 Release Candidate **what is the change?:** We update the versions of all associated React packages when bumping the version of React. **why make this change?:** We want to publish a RC to give folks time to try out the latest version before it's final. Why bump the version of every other associated package? It makes the dependency between them more clear. There will be cases where we make a fix in React-DOM and it requires changes in React core. In that case, it will be more clear to people when we update the versions of both and they remain in sync. **test plan:** Visual inspection **issue:** facebook#9398 * Update a couple more packages versions **what is the change?:** Updates version for 'react-dom-factories' package and 'react-addons' template. **why make this change?:** We missed these in the previous commit, which was copying the approach from https://github.com/facebook/react/pull/9828/files **test plan:** Visual inspection, and running the build **issue:** facebook#9398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
We update the versions of all associated React packages when bumping the
version of React.
why make this change?:
We want to publish a RC to give folks time to try out the latest version
before it's final.
Why bump the version of every other associated package?
It makes the dependency between them more clear.
There will be cases where we make a fix in React-DOM and it requires
changes in React core. In that case, it will be more clear to people
when we update the versions of both and they remain in sync.
test plan:
Visual inspection
issue:
#9398