-
Notifications
You must be signed in to change notification settings - Fork 47.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build process to all addons #9946
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/** | ||
* Copyright 2015-present, Facebook, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
* | ||
* @emails react-core | ||
*/ | ||
|
||
'use strict'; | ||
|
||
var fs = require('fs'); | ||
var path = require('path'); | ||
|
||
// This lets us import Webpack config without crashing | ||
process.env.NODE_ENV = 'development'; | ||
|
||
// This script runs from the addon folder | ||
var exportName = require(path.resolve(process.cwd(), './webpack.config')).output | ||
.library; | ||
var packageName = path.basename(process.cwd()); | ||
|
||
if (packageName.indexOf('react-addons') !== 0) { | ||
throw new Error( | ||
'Only run this script for packages that used to be published as addons.' | ||
); | ||
} | ||
|
||
// Inputs | ||
// DEV: root["exportName"] = factory(root["React"]) | ||
// PROD: e.exportName=t(e.React) | ||
var find = new RegExp( | ||
'((?!exports)\\b\\w+)(\\["' + | ||
exportName + | ||
'"\\]|\\.' + | ||
exportName + | ||
')\\s*=\\s*(\\w+)\\((.*)\\)' | ||
); | ||
// Outputs | ||
// DEV: (root.React ? (root.React.addons = root.React.addons || {}) : /* throw */).exportName = factory(/* ... */); | ||
// PROD: (e.React ? (e.React.addons = e.React.addons || {}) : /* throw */).exportName = t(/* ... */) | ||
var throwIIFE = [ | ||
'(function(){', | ||
'throw new Error("' + | ||
packageName + | ||
' could not find the React object. If you are using script tags, make sure that React is being loaded before ' + | ||
packageName + | ||
'.")', | ||
'})()', | ||
].join(''); | ||
var replace = | ||
'($1.React?($1.React.addons=$1.React.addons||{}):' + | ||
throwIIFE + | ||
').' + | ||
exportName + | ||
'=$3($4)'; | ||
|
||
console.log('Tweaking the development UMD...'); | ||
var devUMD = fs.readFileSync('./' + packageName + '.js', 'utf8').toString(); | ||
devUMD = devUMD.replace(find, replace); | ||
fs.writeFileSync('./' + packageName + '.js', devUMD); | ||
|
||
console.log('Tweaking the production UMD...'); | ||
var prodUMD = fs | ||
.readFileSync('./' + packageName + '.min.js', 'utf8') | ||
.toString(); | ||
prodUMD = prodUMD.replace(find, replace); | ||
fs.writeFileSync('./' + packageName + '.min.js', prodUMD); | ||
|
||
console.log('Done.'); | ||
console.log('Note that you need to manually test the UMD builds.'); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
react-addons-create-fragment.js | ||
react-addons-create-fragment.min.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/** | ||
* Copyright 2013-present, Facebook, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
* | ||
* @emails react-core | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const webpack = require('webpack'); | ||
|
||
let __DEV__; | ||
switch (process.env.NODE_ENV) { | ||
case 'development': | ||
__DEV__ = true; | ||
break; | ||
case 'production': | ||
__DEV__ = false; | ||
break; | ||
default: | ||
throw new Error('Unknown environment.'); | ||
} | ||
|
||
module.exports = { | ||
entry: './index', | ||
output: { | ||
library: 'createFragment', | ||
libraryTarget: 'umd', | ||
filename: __DEV__ | ||
? 'react-addons-create-fragment.js' | ||
: 'react-addons-create-fragment.min.js', | ||
}, | ||
externals: { | ||
react: { | ||
root: 'React', | ||
commonjs2: 'react', | ||
commonjs: 'react', | ||
amd: 'react', | ||
}, | ||
}, | ||
plugins: [ | ||
new webpack.DefinePlugin({ | ||
'process.env.NODE_ENV': __DEV__ ? '"development"' : '"production"', | ||
}), | ||
].concat( | ||
__DEV__ | ||
? [] | ||
: [ | ||
new webpack.optimize.UglifyJsPlugin({ | ||
compress: { | ||
warnings: false, | ||
}, | ||
output: { | ||
comments: false, | ||
}, | ||
}), | ||
] | ||
), | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
react-addons-linked-state-mixin.js | ||
react-addons-linked-state-mixin.min.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test UMDs, but then this script overrides them to tack things onto
React.addons
object.It would be nice to make this more solid but I'm a bit out of ideas or care here. I'll test that it works manually later and I'd just leave it at that. It's still better than lack of any tests..