Fix off by one in OriginalNamePass check #473
Conversation
This PR fixes a bug in `strncmp("LX/", cls_type->get_name()->c_str(), 2)` where the size parameter should be 3. When it is 2 this call will miss checking for the `/` character.
|
Hi @disconnect3d! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Seems legit. Thanks for finding the error! Once the CLA is signed, I can import this PR and get it into the repo. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@justinjhendrick done |
There was a problem hiding this comment.
@justinjhendrick has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@justinjhendrick merged this pull request in 6f5bafd. |
This PR fixes a bug in
strncmp("LX/", cls_type->get_name()->c_str(), 2)where the size parameter should be 3. When it is 2 this call will miss checking for the/character.