Skip to content

Commit

Permalink
de-hastify relay-runtime/subscription
Browse files Browse the repository at this point in the history 
Reviewed By: dwwoelfel

Differential Revision: D7209118

fbshipit-source-id: 109c291e499de4ad4c0434db6f4e31db175993d6
  • Loading branch information
@kassens @facebook-github-bot
kassens authored and facebook-github-bot committed Mar 14, 2018
1 parent 13deecf commit 8af60b7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
5 changes: 4 additions & 1 deletion packages/relay-runtime/RelayRuntime.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,12 @@ const commitRelayModernMutation = require('commitRelayModernMutation');
const fetchRelayModernQuery = require('fetchRelayModernQuery');
const isRelayModernEnvironment = require('isRelayModernEnvironment');
const recycleNodesInto = require('recycleNodesInto');
const requestRelaySubscription = require('requestRelaySubscription');
const requestRelaySubscription = require('./subscription/requestRelaySubscription');
const simpleClone = require('simpleClone');

export type {
GraphQLSubscriptionConfig,
} from './subscription/requestRelaySubscription';
export type {
CacheConfig,
DataID,
Expand Down
2 changes: 1 addition & 1 deletion packages/relay-runtime/subscription/__tests__/requestRelaySubscription-test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

'use strict';

const requestRelaySubscription = require('requestRelaySubscription');
const requestRelaySubscription = require('../requestRelaySubscription');

const {createMockEnvironment} = require('RelayModernMockEnvironment');
const {createOperationSelector} = require('RelayModernOperationSelector');
Expand Down
1 change: 0 additions & 1 deletion packages/relay-runtime/subscription/requestRelaySubscription.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @providesModule requestRelaySubscription
* @flow
* @format
*/
Expand Down

3 comments on commit 8af60b7

@alloy
Copy link
Contributor

@alloy alloy commented on 8af60b7 Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens Might be worthwhile to look at this PR rather than duplicating efforts #2367

@kassens
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alloy Thanks for highlighting the PR. Unfortunately, the biggest issue is internally where lots of code requires internal modules for various purposes. That's why I had to revert this commit for now as well.

@alloy
Copy link
Contributor

@alloy alloy commented on 8af60b7 Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens I see. Mind leaving that feedback on the PR?

Please sign in to comment.