Skip to content

Commit

Permalink
Enable -Wdeprecated-copy-with-dtor and -Wdeprecated-copy-with-user-pr…
Browse files Browse the repository at this point in the history
…ovided-dtor compiler flags

Summary:
These flags disallow implicitly generated constructors for classes that have a user-provided destructor (such as base classes with a virtual destructor).

Thus, explicit default constructors have been provided for all the classes that need them.

Differential Revision: D68797540

fbshipit-source-id: 4aec3fd243b6ee773f1e4ac21eb3e0eb276cf4af
  • Loading branch information
Jonathan McCue authored and facebook-github-bot committed Feb 12, 2025
1 parent 4e42cee commit 5b7c367
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions wangle/acceptor/ServerSocketConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ namespace wangle {
*/
class CustomConfig {
public:
CustomConfig() = default;
CustomConfig(const CustomConfig&) = default;
CustomConfig(CustomConfig&&) = default;
CustomConfig& operator=(const CustomConfig&) = default;
CustomConfig& operator=(CustomConfig&&) = default;
virtual ~CustomConfig() = default;
};

Expand Down
4 changes: 4 additions & 0 deletions wangle/ssl/SSLContextConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ namespace wangle {

struct SSLContextConfig {
SSLContextConfig() = default;
SSLContextConfig(const SSLContextConfig&) = default;
SSLContextConfig(SSLContextConfig&&) = default;
SSLContextConfig& operator=(const SSLContextConfig&) = default;
SSLContextConfig& operator=(SSLContextConfig&&) = default;
virtual ~SSLContextConfig() = default;

struct CertificateInfo {
Expand Down

0 comments on commit 5b7c367

Please sign in to comment.