Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YogaKit for non-swift iOS projects #565

Closed
atkit opened this issue May 25, 2017 · 1 comment
Closed

YogaKit for non-swift iOS projects #565

atkit opened this issue May 25, 2017 · 1 comment

Comments

@atkit
Copy link

atkit commented May 25, 2017

Currently when YogaKit is installed it brings some swift into project (and for some projects it might be a problem, bundle size for example).

I propose to bring YogaKit swift extensions as separate podspec or subspec, to give a choice:

  • for pure Obj-C projects use YogaKit Obj-C only
  • for mixed or pure Swift Projects to have everything in place
Installing YogaKit (1.5.0)
[!] Pods written in Swift can only be integrated as frameworks; add `use_frameworks!` to your Podfile or target to opt into using it. The Swift Pod being used is: YogaKit
This was referenced Jul 13, 2017
Closed
Closed
facebook-github-bot pushed a commit that referenced this issue Nov 7, 2019
@priteshrnandgaonkar @facebook-github-bot
Add Swift extension as a separate pod
ddf748a 
Summary:
Adds swift extension file as a separate subspec, as it is not required for the objc projects.

Also this fixes the current issue where the flipper sample app fails to build on xcode 11, as it fails to link the Swift specific literals.

Fixes this too #565

Reviewed By: SidharthGuglani

Differential Revision: D18373993

fbshipit-source-id: 0c058886a837c7ceafcd0167f878b3e0f7763aa1
tobster-de pushed a commit to RECOMGmbH/Yoga that referenced this issue Oct 30, 2020
@priteshrnandgaonkar @tobster-de
Add Swift extension as a separate pod
a44af32 
Summary:
Adds swift extension file as a separate subspec, as it is not required for the objc projects.

Also this fixes the current issue where the flipper sample app fails to build on xcode 11, as it fails to link the Swift specific literals.

Fixes this too facebook#565

Reviewed By: SidharthGuglani

Differential Revision: D18373993

fbshipit-source-id: 0c058886a837c7ceafcd0167f878b3e0f7763aa1
@NickGerleman
Copy link
Contributor

It looks like this was resolved by the linked commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dividied YogaKit.podspec into Core and SwiftExtension for YogaKit. atkit/yoga
2 participants
@atkit @NickGerleman