This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Expose path to Draft.css for usage by CSS pre-processors #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** CREDIT TO @darobin for this change, originally made in facebookarchive#566 --- Some CSS pre-processors understand node_modules and are able to @import without requiring an absolute path. However, without assistance from the module all that they can resolve is its root directory. This leads to @import statements like the following: ``` @import "draft-js/dist/Draft.css"; ``` While this works, it requires internal knowledge of the package's layout. This requires digging around and if the layout changes, this breaks. These pre-processors also recognise a style field in package.json, which is the equivalent of main for CSS. This allows one to import thusly: ``` @import "draft-js"; ``` It's a small change, but it helps!
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
Summary: **what is the change?:** CREDIT TO darobin for this change, originally made in facebookarchive/draft-js#566 --- Some CSS pre-processors understand node_modules and are able to import without requiring an absolute path. However, without assistance from the module all that they can resolve is its root directory. This leads to import statements like the following: ``` import "draft-js/dist/Draft.css"; ``` While this works, it requires internal knowledge of the package's layout. This requires digging around and if the layout changes, this breaks. These pre-processors also recognise a style field in package.json, which is the equivalent of main for CSS. This allows one to import thusly: ``` import "draft-js"; ``` It's a small change, but it helps! Closes facebookarchive/draft-js#1442 Differential Revision: D6088534 fbshipit-source-id: fcede534a18620907adfb6a30391b9f722756e8c
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **what is the change?:** CREDIT TO darobin for this change, originally made in facebookarchive/draft-js#566 --- Some CSS pre-processors understand node_modules and are able to import without requiring an absolute path. However, without assistance from the module all that they can resolve is its root directory. This leads to import statements like the following: ``` import "draft-js/dist/Draft.css"; ``` While this works, it requires internal knowledge of the package's layout. This requires digging around and if the layout changes, this breaks. These pre-processors also recognise a style field in package.json, which is the equivalent of main for CSS. This allows one to import thusly: ``` import "draft-js"; ``` It's a small change, but it helps! Closes facebookarchive/draft-js#1442 Differential Revision: D6088534 fbshipit-source-id: fcede534a18620907adfb6a30391b9f722756e8c
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **what is the change?:** CREDIT TO darobin for this change, originally made in facebookarchive/draft-js#566 --- Some CSS pre-processors understand node_modules and are able to import without requiring an absolute path. However, without assistance from the module all that they can resolve is its root directory. This leads to import statements like the following: ``` import "draft-js/dist/Draft.css"; ``` While this works, it requires internal knowledge of the package's layout. This requires digging around and if the layout changes, this breaks. These pre-processors also recognise a style field in package.json, which is the equivalent of main for CSS. This allows one to import thusly: ``` import "draft-js"; ``` It's a small change, but it helps! Closes facebookarchive/draft-js#1442 Differential Revision: D6088534 fbshipit-source-id: fcede534a18620907adfb6a30391b9f722756e8c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
CREDIT TO @darobin for this change, originally made in
#566
Some CSS pre-processors understand node_modules and are able to @import without requiring an absolute path. However, without assistance from the module all that they can resolve is its root directory. This leads to @import statements like the following:
While this works, it requires internal knowledge of the package's layout. This requires digging around and if the layout changes, this breaks.
These pre-processors also recognise a style field in package.json, which is the equivalent of main for CSS. This allows one to import thusly:
It's a small change, but it helps!