This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Timeout error raised by FileWatcher is silently swallowed #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the MAX_WAIT_TIME timeout is reached, the error that is thrown by FileWatcher is swallowed by the _loading Promise and thus it nevers gets to the caller. This can be fixed by adding a 'done' block to this promise. Also, some of the messages that are displayed to the user should be a bit more clearer.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
| ]; | ||
| if (Watcher === sane.WatchmanWatcher) { | ||
| lines.push( | ||
| 'Try running `watchman version` from your terminal', | ||
| 'https://facebook.github.io/watchman/docs/troubleshooting.html', | ||
| ); | ||
| } else { | ||
| lines.push('The current library being used by the file watcher is NodeWatcher. We recommend you install Watchman on your system (http://facebook.github.io/watchman/) and run the app again to check if file crawling runs faster then.'); |
|
Also, add a test, please. And make sure it fails without your changes. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the MAX_WAIT_TIME timeout is reached, the error that is thrown by
FileWatcher is swallowed by the _loading Promise and thus it nevers gets
to the caller. This can be fixed by adding a 'done' block to this
promise.
Also, some of the messages that are displayed to the user should be a
bit more clearer.