Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly a minor labelling issue in the Actual vs. Predicted Response chart. #1187

Open
SeanRichterWalsh opened this issue Dec 11, 2024 · 2 comments
Assignees

Comments

@SeanRichterWalsh
Copy link

SeanRichterWalsh commented Dec 11, 2024

Project Robyn

Describe issue

Odd labelling issue in the Actual vs. Predicted Response chart. If you extract the underlying data used for the chart , the linetype variable has dotted for actual and solid for predicted but this is different than what the chart legend shows.

Provide reproducible example

Using the dummy data in Robyn:
image

Environment & Robyn version

Robyn 3.11.1
R version 4.4.0 (2024-04-24)

@gufengzhou
Copy link
Contributor

hey @laresbernardo can you have a look please whenever you have a minute?

@laresbernardo
Copy link
Collaborator

The linetype column isn't actually required on this plot. I've fixed it now in my branch (will do a PR in a moment) and the user will only see the ds, variable, and value columns now in the underlying data for this plot. The output plot is exactly the same plot.

laresbernardo added a commit that referenced this issue Dec 23, 2024
…ata on actual vs predicted plot (#1193)

* fix: calibration error .min_max_norm(.data$mape) Caused by error different vector sizes
* fix: underlying data for actual vs predicted (linetype) #1187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants