Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing log output (hyperparameters check) #474

Closed
sallyhong opened this issue Aug 28, 2022 · 1 comment · Fixed by sallyhong/Robyn#1
Closed

Confusing log output (hyperparameters check) #474

sallyhong opened this issue Aug 28, 2022 · 1 comment · Fixed by sallyhong/Robyn#1
Assignees
@laresbernardo
Labels
bug Something isn't working

Comments

@sallyhong
Copy link

sallyhong commented Aug 28, 2022 •
edited
Loading

Project Robyn

Describe issue

in the facebookexperimental/Robyn/R/R/checks.R file,
image
The output is reversed.
Line 432 should be total_in, total

Provide reproducible example

image

I literally provided 6 parameters, but 12 were required.

Environment & Robyn version

Robyn v3.7.1
sallyhong added a commit to sallyhong/Robyn that referenced this issue Aug 28, 2022
@sallyhong
Update hyperparameter check debug output
ae76ba8 
Quick fix :)

Reference issue: facebookexperimental#474
@sallyhong sallyhong mentioned this issue Aug 28, 2022
Merged
laresbernardo added a commit that referenced this issue Aug 29, 2022
@laresbernardo
fix: inverted counters in check_hyperparameters() #474
aad1446
@laresbernardo laresbernardo self-assigned this Aug 29, 2022
@laresbernardo laresbernardo added the bug Something isn't working label Aug 29, 2022
@laresbernardo
Copy link
Collaborator

Thanks for reporting this mistake @sallyhong Fixed! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laresbernardo laresbernardo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update hyperparameter check debug output sallyhong/Robyn
2 participants
@sallyhong @laresbernardo