Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New upgrade to 3.8 giving error in robyn_inputs #520

Closed
virithavanama opened this issue Oct 28, 2022 · 23 comments
Closed

New upgrade to 3.8 giving error in robyn_inputs #520

virithavanama opened this issue Oct 28, 2022 · 23 comments
Assignees
Labels
bug Something isn't working

Comments

@virithavanama
Copy link

Hi Team,

I have upgraded to the new Robyn 3.8 version and getting the below error:
Screen Shot 2022-10-28 at 9 30 11 AM

@laresbernardo laresbernardo self-assigned this Oct 28, 2022
@laresbernardo laresbernardo added the bug Something isn't working label Oct 28, 2022
@laresbernardo
Copy link
Collaborator

Thanks for reporting this bug @virithavanama I've updated main branch, can you please update and re-try?

@virithavanama
Copy link
Author

Thanks, @laresbernardo for the prompt fix :)
Now I get a new issue when running robyn_run:
Screen Shot 2022-10-28 at 11 26 56 AM

@laresbernardo
Copy link
Collaborator

Can you please share a reproducible example as I can't seem to be able to reproduce this one?

@DpfStat
Copy link

DpfStat commented Nov 1, 2022

Same issue with 3.8.0 for running robyn_run. If use the same data set with 3.7.2, no error.

@firatfrkn
Copy link

The same issue I am having
Screenshot 2022-11-01 112633

@gufengzhou
Copy link
Contributor

We can't reproduce the same error. Could you please share an anonymised dataset for us to debug. thanks

gufengzhou added a commit that referenced this issue Nov 1, 2022
@gufengzhou
Copy link
Contributor

@firatfrkn Thanks for providing the anonymous dataset for debugging. I've just pushed the fix. It runs now on my side. Can you please update the package and check.

@firatfrkn
Copy link

thanks a lot. It works for me now

@gufengzhou
Copy link
Contributor

cool thanks for confirming. you can check the fix detail in the commit here

@AruunnAnanda
Copy link

@gufengzhou I still have the same problem after updating to v3.8.1. To update I ran the command - Robyn::robyn_update()
image

@gufengzhou
Copy link
Contributor

gufengzhou commented Nov 1, 2022

strange. have you checked packageVersion("Robyn") that's v3.8.1 and restarted the R session? If it's still there, I'd need an anonymous dataset from to you debug.

@AruunnAnanda
Copy link

AruunnAnanda commented Nov 1, 2022

@gufengzhou Yes, I did.

This time the error is - Error in {: task 1 failed - "non-numeric argument to binary operator"

This error is different than the last time. I'm attaching the last time error here.

image

@gufengzhou
Copy link
Contributor

gufengzhou commented Nov 1, 2022

Please provide your dataset anonymised and your model specification in robyn_inputs() and hyperparameters for debugging. you can send it to [email protected]

@gufengzhou
Copy link
Contributor

Hey @AruunnAnanda , I managed to reproduce your error and just pushed a fix. Could you please update and retest. thanks

@AruunnAnanda
Copy link

AruunnAnanda commented Nov 2, 2022

Hey @gufengzhou, I unfortunately still have the same error.

If I don't use calibration as an input the model RUNS FINE.

If I start using calibration as an input the model throws an error

gufengzhou added a commit that referenced this issue Nov 2, 2022
This reverts commit 4f81ffc.
@gufengzhou
Copy link
Contributor

ok that's an important information missing that you used calibration. I'll check and get back.

@gufengzhou
Copy link
Contributor

@AruunnAnanda Please update and check

@AruunnAnanda
Copy link

@gufengzhou I still have the same issue :(

I sent you the anonymised data via email to replicate and debug.

@gufengzhou
Copy link
Contributor

thanks for the data. I've just pushed another fix and it runs on my macbook. please update and try

@virithavanama
Copy link
Author

Thanks for the bug fixes. robyn_inputs issue is fixed for me too! But now having an issue with robyn_outputs:
image

@gufengzhou
Copy link
Contributor

there's been some fixes since then. can you update the package incl. dependencies, restart R and retry please?

@gufengzhou
Copy link
Contributor

This should be fixed with the latest commits. Please update and check

@gufengzhou
Copy link
Contributor

Please reopen if issue reoccurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants