Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a penalty factor during initial model build will not allow for a model refresh #543

Closed
jsabastian opened this issue Nov 21, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jsabastian
Copy link

Project Robyn

Describe issue

Setting the experimental parameter 'add_penalty_factor = TRUE' during the initial model build will not allow the 'check_hyper_fixed()' function to pass, resulting in the following error:

Error in check_hyper_fixed(InputCollect, dt_hyper_fixed, add_penalty_factor) :
Input 'dt_hyper_fixed' is invalid. Please provide 'OutputCollect$resultHypParam' result from previous runs or 'pareto_hyperparameters.csv' data with desired model ID

Robyn Open Source MMM Users Post

Link

Environment & Robyn version

Make sure you're using the latest Robyn version before you post an issue.

  • Robyn 3.8.1
  • R version 4.2.2
@laresbernardo laresbernardo added the bug Something isn't working label Nov 21, 2022
@laresbernardo
Copy link
Collaborator

Correction on description to be able to replicate this bug: initial model runs OK, but when refreshing with robyn_refresh() user gets posted error.

@laresbernardo
Copy link
Collaborator

Ok, I've just pushed a fix. Given it's an experimental feature, it's expected to suffer some changes such as these: now the names of the hyperparameters for penalization ends (not starts anymore) with "_penalty" to keep the same format as the other hyperparameters (and show up in the prints nicely like attached image).

Screen Shot 2022-11-21 at 7 09 24 PM

If you can please update to latest dev version, recreate your original model, export JSON file and run robyn_refresh() it should run smoothly. Please, let me know if that is or isn't the case so we can FUP or close this bug. Thanks @jsabastian

@jsabastian
Copy link
Author

@laresbernardo Rebuild of the model using the penalty parameter refreshed correctly. Thanks for the fix! Also, I like the pareto front progress bar!

@laresbernardo
Copy link
Collaborator

Thanks, glad you found it useful. And thanks for checking back, I'll close this thread but feel free to reopen it if you get any further issues or comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants