Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhacne: robyn api handle transform with promises and metux #1058

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TankyH
Copy link

@TankyH TankyH commented Sep 15, 2024

Project Robyn

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: API change with a documentation update
  • test: Additional test coverage
  • reformat: Code cleanup, recoding or reformating code

How Has This Been Tested?

  • Fork the repo and create your branch from master (latest dev version).
  • If you've changed docuemntation, run devtools::document(). Should update .Rd files.
  • Ensure all tests pass, run devtools::check(). Should have no notes, no warning, no errors.
  • Make sure your code lints.

@facebook-github-bot
Copy link

Hi @TankyH!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@TankyH TankyH force-pushed the tengqiu.huang/add-promises branch from 7dccf20 to 53df7e2 Compare September 15, 2024 13:37
@TankyH TankyH force-pushed the tengqiu.huang/add-promises branch from 9864303 to 7b2940d Compare September 15, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants